Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1739100

Re: [PATCH 4/7] page-writeback: pass in '0' for nr_pages writeback in laptop mode

Show all headers | View raw

On 09/21/2017 08:59 AM, Christoph Hellwig wrote:
> On Wed, Sep 20, 2017 at 09:32:59AM -0600, Jens Axboe wrote:
>> Laptop mode really wants to writeback the number of dirty
>> pages and inodes. Instead of calculating this in the caller,
>> just pass in 0 and let wakeup_flusher_threads() handle it.
>>
>> Use the new wakeup_flusher_threads_bdi() instead of rolling
>> our own. This changes the writeback to not be range cyclic,
>> but that should not matter for laptop mode flush-all
>> semantics.
> 
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> 
> While we're at sorting out the laptop_mode_wb_timer mess:
> can we move initializing and deleting it from the block code
> to the backing-dev code given that it now doesn't assume anything
> about block devices any more?

Good point, I'll include that in a followup for 4.15.

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 4/7] page-writeback: pass in '0' for nr_pages writeback in laptop mode Jens Axboe <axboe@kernel.dk> - 2017-09-20 17:40 +0200
  Re: [PATCH 4/7] page-writeback: pass in '0' for nr_pages writeback  in laptop mode Christoph Hellwig <hch@infradead.org> - 2017-09-21 17:00 +0200
    Re: [PATCH 4/7] page-writeback: pass in '0' for nr_pages writeback in  laptop mode Jens Axboe <axboe@kernel.dk> - 2017-09-25 17:00 +0200
  Re: [PATCH 4/7] page-writeback: pass in '0' for nr_pages writeback  in laptop mode Christoph Hellwig <hch@infradead.org> - 2017-09-21 17:10 +0200
  Re: [PATCH 4/7] page-writeback: pass in '0' for nr_pages writeback  in laptop mode Jan Kara <jack@suse.cz> - 2017-09-22 15:20 +0200

csiph-web