Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1739091

Re: [PATCH v3] staging: greybus: light: Release memory obtained by kasprintf

Show all headers | View raw

Hi,
On Sat, Sep 23, 2017 at 01:25:30PM +0530, Arvind Yadav wrote:
> Free memory region, if gb_lights_channel_config is not successful.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Thanks for the patch, looks good to me.

Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>

---
Cheers,
	Rui

> ---
> changes in v2:
>             - Subject line changed.
>             - add kfree in __gb_lights_led_unregister().
>             - No need to check return value of gb_lights_channel_flash_config().
> 
> changes ib v3:
>             - separate patch for "No need to check return value of
>               gb_lights_channel_flash_config()".
> 
>  drivers/staging/greybus/light.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
> index 3f4148c..0f538b8 100644
> --- a/drivers/staging/greybus/light.c
> +++ b/drivers/staging/greybus/light.c
> @@ -925,6 +925,8 @@ static void __gb_lights_led_unregister(struct gb_channel *channel)
>  		return;
>  
>  	led_classdev_unregister(cdev);
> +	kfree(cdev->name);
> +	cdev->name = NULL;
>  	channel->led = NULL;
>  }
>  
> -- 
> 2.7.4
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] staging: greybus: light: Release memory obtained by kasprintf Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-23 10:00 +0200
  Re: [PATCH v3] staging: greybus: light: Release memory obtained by  kasprintf Rui Miguel Silva <rmfrfs@gmail.com> - 2017-09-25 16:30 +0200

csiph-web