Re: [PATCH v2 2/3] KEYS: don't revoke uninstantiated key in request_key_auth_new()

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/3] KEYS: don't revoke uninstantiated key in request_key_auth_new()
Date	2017-09-25 16:20 +0200
Message-ID	<utCoN-7tX-13@gated-at.bofh.it> (permalink)
References	<usgJI-5J0-11@gated-at.bofh.it> <usgJI-5J0-3@gated-at.bofh.it> <usgJI-5J0-11@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Eric Biggers <ebiggers3@gmail.com> wrote:

> Fix this by removing the call to key_revoke().  key_put() is sufficient,
> as it's not possible for an uninstantiated authkey to have been used for
> anything yet.

Note that the owner can call keyctl_describe() upon it, though that shouldn't
wait because KEY_LOOKUP_PARTIAL would be specified.

However, this is probably fair enough, and it should be gc'd quickly because
it'll lose its last ref.

David

Thread

[PATCH v2 0/3] KEYS: fix error handling in request_key_auth_new() Eric Biggers <ebiggers3@gmail.com> - 2017-09-21 23:00 +0200
  [PATCH v2 2/3] KEYS: don't revoke uninstantiated key in request_key_auth_new() Eric Biggers <ebiggers3@gmail.com> - 2017-09-21 23:00 +0200
    Re: [PATCH v2 2/3] KEYS: don't revoke uninstantiated key in request_key_auth_new() David Howells <dhowells@redhat.com> - 2017-09-25 16:20 +0200
  [PATCH v2 3/3] KEYS: use kmemdup() in request_key_auth_new() Eric Biggers <ebiggers3@gmail.com> - 2017-09-21 23:00 +0200
  [PATCH v2 1/3] KEYS: fix cred refcount leak in request_key_auth_new() Eric Biggers <ebiggers3@gmail.com> - 2017-09-21 23:00 +0200
    Re: [PATCH v2 1/3] KEYS: fix cred refcount leak in request_key_auth_new() David Howells <dhowells@redhat.com> - 2017-09-25 16:30 +0200

csiph-web