Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1739031

Re: [PATCH V7 1/2] dma-mapping: Rework dma_get_cache_alignment()

Show all headers | View raw

> index aba7138..e2c5d9e 100644
> --- a/arch/mips/include/asm/dma-mapping.h
> +++ b/arch/mips/include/asm/dma-mapping.h
> @@ -39,4 +39,6 @@ static inline void arch_setup_dma_ops(struct device *dev, u64 dma_base,
>  #endif
>  }
>  
> +int mips_get_cache_alignment(struct device *dev);

All the other mips generic dma helpers are prefixed mips_dma_*
so it might make sense to follow that.

Also please don't add arch-local helpers to asm/dma-mapping.h - this
is a header used by linux/dma-mapping.h and should not contain
implementation details if avoidable.

> +					   dma_get_cache_alignment(NULL)) / mdev->limits.mtt_seg_size;

As said before - please don't pass NULL to this function but the proper
device, which would be &mdev->pdev->dev in this case for example.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V7 1/2] dma-mapping: Rework dma_get_cache_alignment() Huacai Chen <chenhc@lemote.com> - 2017-09-25 12:10 +0200
  Re: [PATCH V7 1/2] dma-mapping: Rework dma_get_cache_alignment() Robin Murphy <robin.murphy@arm.com> - 2017-09-25 15:00 +0200
    Re: [PATCH V7 1/2] dma-mapping: Rework dma_get_cache_alignment() "陈华才" <chenhc@lemote.com> - 2017-09-26 03:50 +0200
  Re: [PATCH V7 1/2] dma-mapping: Rework dma_get_cache_alignment() Christoph Hellwig <hch@lst.de> - 2017-09-25 15:00 +0200
    Re: [PATCH V7 1/2] dma-mapping: Rework dma_get_cache_alignment() "陈华才" <chenhc@lemote.com> - 2017-09-26 03:50 +0200
      Re: [PATCH V7 1/2] dma-mapping: Rework dma_get_cache_alignment() Christoph Hellwig <hch@lst.de> - 2017-09-26 08:20 +0200

csiph-web