Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1738114
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: ALSA: bebob: Use common error handling code in snd_bebob_stream_start_duplex() |
| Date | 2017-09-24 09:10 +0200 |
| Message-ID | <ut9d7-5Gg-11@gated-at.bofh.it> (permalink) |
| References | <umFKO-lj-5@gated-at.bofh.it> <umFKO-lj-11@gated-at.bofh.it> <ut6ff-3Eq-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> 668 if (!amdtp_stream_wait_callback(&bebob->tx_stream,
> 669 CALLBACK_TIMEOUT)) {
> 670 amdtp_stream_stop(&bebob->tx_stream);
> 671 amdtp_stream_stop(&bebob->rx_stream);
> 672 break_both_connections(bebob);
> 673 err = -ETIMEDOUT;
> 674 }
> 675 }
>
> I think it better to apply your solution too in the above to keep code consistency.
How do you think about to adjust this function implementation after the other two
update steps from the patch series would be integrated?
> For the other patches, I can find no merit to apply except for reduction
> of the number of characters included in the file.
Would you like to refer to any specific update suggestions for further clarification?
Regards,
Markus
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Re: [PATCH 1/3] ALSA: bebob: Use common error handling code in snd_bebob_stream_start_duplex() Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2017-09-24 06:00 +0200 Re: ALSA: bebob: Use common error handling code in snd_bebob_stream_start_duplex() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-24 09:10 +0200
csiph-web