Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1738081

Re: [PATCH v2] staging: bcm2835-audio: Fix memory corruption

Show all headers | View raw

Hi Phil,

> Greg Kroah-Hartman <gregkh@linuxfoundation.org> hat am 23. September 2017 um 18:15 geschrieben:
> 
> 
> On Sat, Sep 23, 2017 at 12:57:33PM +0200, Stefan Wahren wrote:
> > Hi Greg,
> > 
> > > Phil Elwell <phil@raspberrypi.org> hat am 11. August 2017 um 12:20 geschrieben:
> > > 
> > > 
> > > The previous commit (0adbfd46) fixed a memory leak but also freed a
> > > block in the success case, causing a stale pointer to be used with
> > > potentially fatal results. Only free the vchi_instance block in the
> > > case that vchi_connect fails; once connected, the instance is
> > > retained for subsequent connections.
> > > 
> > > Simplifying the code by removing a bunch of gotos and returning errors
> > > directly.
> > > 
> > > Signed-off-by: Phil Elwell <phil@raspberrypi.org>
> > > Fixes: 0adbfd4694c2 ("staging: bcm2835-audio: fix memory leak in bcm2835_audio_open_connection()")
> > 
> > can you still apply this patch or do you need a resend?
> 
> Hm, I don't see this anywhere in my tree, or in my todo mbox, so yes,
> please resend it, thanks.

could you please resend this patch?

Thanks
Stefan

> 
> greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] staging: bcm2835-audio: Fix memory corruption Stefan Wahren <stefan.wahren@i2se.com> - 2017-09-23 13:00 +0200
  Re: [PATCH v2] staging: bcm2835-audio: Fix memory corruption Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-23 18:20 +0200
    Re: [PATCH v2] staging: bcm2835-audio: Fix memory corruption Stefan Wahren <stefan.wahren@i2se.com> - 2017-09-24 00:50 +0200

csiph-web