Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1737687

Re: [PATCH] brcm80211: make const array ucode_ofdm_rates static, reduces object code size

Show all headers | View raw

Please use 'brcmsmac:' as prefix instead of 'brcm80211:'.

On 22-09-17 16:03, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Don't populate const array ucode_ofdm_rates on the stack, instead make it
> static. Makes the object code smaller by 100 bytes:
> 
> Before:
>     text	   data	    bss	    dec	    hex	filename
>    39482	    564	      0	  40046	   9c6e	phy_cmn.o
> 
> After
>     text	   data	    bss	    dec	    hex	filename
>    39326	    620	      0	  39946	   9c0a	phy_cmn.o
> 
> (gcc 6.3.0, x86-64)

Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c
> index 1c4e9dd57960..3a13d176b221 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_cmn.c
> @@ -1916,7 +1916,7 @@ void wlc_phy_txpower_update_shm(struct brcms_phy *pi)
>   				     pi->hwpwr_txcur);
>   
>   		for (j = TXP_FIRST_OFDM; j <= TXP_LAST_OFDM; j++) {
> -			const u8 ucode_ofdm_rates[] = {
> +			static const u8 ucode_ofdm_rates[] = {
>   				0x0c, 0x12, 0x18, 0x24, 0x30, 0x48, 0x60, 0x6c
>   			};
>   			offset = wlapi_bmac_rate_shm_offset(
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] brcm80211: make const array ucode_ofdm_rates static, reduces object code size Colin King <colin.king@canonical.com> - 2017-09-22 16:10 +0200
  Re: [PATCH] brcm80211: make const array ucode_ofdm_rates static,  reduces object code size Arend van Spriel <arend.vanspriel@broadcom.com> - 2017-09-22 19:00 +0200
    Re: [PATCH] brcm80211: make const array ucode_ofdm_rates static, reduces object code size Kalle Valo <kvalo@codeaurora.org> - 2017-09-25 06:30 +0200
  Re: brcmsmac: make const array ucode_ofdm_rates static,  reduces object code size Kalle Valo <kvalo@codeaurora.org> - 2017-09-25 10:30 +0200

csiph-web