Re: [Intel-wired-lan] [PATCH] i40e: make const array patterns static, reduces object code size

From	Jesse Brandeburg <jesse.brandeburg@intel.com>
Newsgroups	linux.kernel
Subject	Re: [Intel-wired-lan] [PATCH] i40e: make const array patterns static, reduces object code size
Date	2017-09-22 18:50 +0200
Message-ID	<uszjk-8ri-35@gated-at.bofh.it> (permalink)
References	<uswYa-75K-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 22 Sep 2017 15:11:38 +0100
Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> Don't populate const array patterns on the stack, instead make it
> static. Makes the object code smaller by over 60 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>    1953	    496	      0	   2449	    991	i40e_diag.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>    1798	    584	      0	   2382	    94e	i40e_diag.o
> 
> (gcc 6.3.0, x86-64)
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Looks good, thanks Colin!

Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] i40e: make const array patterns static, reduces object code size Colin King <colin.king@canonical.com> - 2017-09-22 16:20 +0200
  Re: [Intel-wired-lan] [PATCH] i40e: make const array patterns  static, reduces object code size Jesse Brandeburg <jesse.brandeburg@intel.com> - 2017-09-22 18:50 +0200

csiph-web