Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1737653

[PATCH v3 0/4] phy: rockchip-typec: Set "flip" properly; some cleanups; fix swing

Show all headers | View raw

When connecting to certain DP monitors it was observed that only one
of the two orientations of the type C to DP cable would work.
Debugging showed that the problem was that we needed to set the type C
"flip" state earlier.  Once we did this, problems went away.

While trying to dig into this problem and some others, I found that
the proper documentation for the Type C PHY was available to me.  This
allowed me to cleanup the magic numbers in the funtion that I was
touching and also fix a few minor issues that (luckily) haven't caused
any problems yet.

I also found that aux channel communications were flaky on some
adapters until I adjusted the voltage swing.

For this series I've added Chris Zhong's Reviewed-by tags to some of
the patches since he gave a +1 to nearly identical patches on the
Chrome OS gerrit and I didn't think he'd mind me carrying his tag.  If
folks would rather I didn't do that, please yell.

Changes in v3:
- Voltage swing patch now patch 2.

Changes in v2:
- Voltage swing patch new for v2.
- Removed extra blank line.

Douglas Anderson (4):
  phy: rockchip-typec: Set the AUX channel flip state earlier
  phy: rockchip-typec: Don't set the aux voltage swing to 400 mV
  phy: rockchip-typec: Avoid magic numbers + add delays in aux calib
  phy: rockchip-typec: Do the calibration more correctly

 drivers/phy/rockchip/phy-rockchip-typec.c | 246 ++++++++++++++++++++++++------
 1 file changed, 201 insertions(+), 45 deletions(-)

-- 
2.14.1.821.g8fa685d3b7-goog

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/4] phy: rockchip-typec: Set "flip" properly; some cleanups; fix swing Douglas Anderson <dianders@chromium.org> - 2017-09-22 18:50 +0200
  [PATCH v3 3/4] phy: rockchip-typec: Avoid magic numbers + add delays in aux calib Douglas Anderson <dianders@chromium.org> - 2017-09-22 18:50 +0200
  [PATCH v3 4/4] phy: rockchip-typec: Do the calibration more correctly Douglas Anderson <dianders@chromium.org> - 2017-09-22 18:50 +0200
  [PATCH v3 2/4] phy: rockchip-typec: Don't set the aux voltage swing to 400 mV Douglas Anderson <dianders@chromium.org> - 2017-09-22 18:50 +0200
  [PATCH v3 1/4] phy: rockchip-typec: Set the AUX channel flip state earlier Douglas Anderson <dianders@chromium.org> - 2017-09-22 18:50 +0200

csiph-web