Re: [PATCH] IB/core: fix incorrect fall-through on switch statement

From	Doug Ledford <dledford@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] IB/core: fix incorrect fall-through on switch statement
Date	2017-09-22 19:20 +0200
Message-ID	<uszMm-oq-15@gated-at.bofh.it> (permalink)
References	<uozrA-5Ep-25@gated-at.bofh.it> <upj1o-1ns-5@gated-at.bofh.it>
Organization	Red Hat, Inc.

Show all headers | View raw

On Wed, 2017-09-13 at 19:49 +0300, Leon Romanovsky wrote:
> On Mon, Sep 11, 2017 at 05:03:13PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > In the case where mbox_status is OCRDMA_MBX_STATUS_FAILED and
> > add_status is OCRDMA_MBX_STATUS_FAILED err_num is assigned -EAGAIN
> > however the case OCRDMA_MBX_STATUS_FAILED is missing a break and
> > falls through to the default case which then re-assigns err_num
> > to -EFAULT.   Fix this so that err_num is assigned to -EAGAIN
> > for the add_status OCRDMA_MBX_STATUS_FAILED case and -EFAULT
> > otherwise.
> > 
> > Detected by CoverityScan CID#703125 ("Missing break in switch")
> > 
> > Fixes: fe2caefcdf58 ("RDMA/ocrdma: Add driver for Emulex OneConnect
> > IBoE RDMA adapter")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> >  drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> 
> Except the wrong title: IB/core -> IB/ocrdma
> 
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

Thanks, patch (with fixed subject) applied.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] IB/core: fix incorrect fall-through on switch statement Colin King <colin.king@canonical.com> - 2017-09-11 18:10 +0200
  Re: [PATCH] IB/core: fix incorrect fall-through on switch statement Leon Romanovsky <leon@kernel.org> - 2017-09-13 18:50 +0200
    Re: [PATCH] IB/core: fix incorrect fall-through on switch statement Doug Ledford <dledford@redhat.com> - 2017-09-22 19:20 +0200

csiph-web