Re: [PATCH] Input: elan_i2c - Extend Flash-Write delay for Elan touch pad

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Input: elan_i2c - Extend Flash-Write delay for Elan touch pad
Date	2017-09-22 19:10 +0200
Message-ID	<uszCG-kW-7@gated-at.bofh.it> (permalink)
References	<uspai-2ll-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 22, 2017 at 01:50:36PM +0800, KT Liao wrote:
> Original 20ms delay is a margin timing after a block writing
> in FW update flow.
> 
> Sometimes it will cause fail during FW-updating if I2C timing delay.
> We offten see this issue in rockchip's I2C host.
> 
> Extend the delay timing is the safest way to improve it.
> 
> Signed-off-by: KT Liao <kt.liao@emc.com.tw>

Applied, thank you.

> ---
>  drivers/input/mouse/elan_i2c_i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/mouse/elan_i2c_i2c.c b/drivers/input/mouse/elan_i2c_i2c.c
> index 80172f2..4db376c 100644
> --- a/drivers/input/mouse/elan_i2c_i2c.c
> +++ b/drivers/input/mouse/elan_i2c_i2c.c
> @@ -587,7 +587,7 @@ static int elan_i2c_write_fw_block(struct i2c_client *client,
>  	}
>  
>  	/* Wait for F/W to update one page ROM data. */
> -	msleep(20);
> +	msleep(35);
>  
>  	error = elan_i2c_read_cmd(client, ETP_I2C_IAP_CTRL_CMD, val);
>  	if (error) {
> -- 
> 2.7.4
> 

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Input: elan_i2c - Extend Flash-Write delay for Elan touch pad KT Liao <kt.liao@emc.com.tw> - 2017-09-22 08:00 +0200
  Re: [PATCH] Input: elan_i2c - Extend Flash-Write delay for Elan  touch pad Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-22 19:10 +0200

csiph-web