Re: [PATCH 0/5] exec: binfmt_misc: fix use-after-free, kill iname[BINPRM_BUF_SIZE]

From	Kees Cook <keescook@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/5] exec: binfmt_misc: fix use-after-free, kill iname[BINPRM_BUF_SIZE]
Date	2017-09-22 17:30 +0200
Message-ID	<usy3T-7Hh-15@gated-at.bofh.it> (permalink)
References	<usxhw-7bZ-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 22, 2017 at 7:36 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> Note: 5/5 depends on
>
>         -extern int bprm_change_interp(char *interp, struct linux_binprm *bprm);
>         +extern int bprm_change_interp(const char *interp, struct linux_binprm *bprm);
>
> change in
>
>         [PATCH] exec: load_script: kill the onstack interp[BINPRM_BUF_SIZE] array
>         https://marc.info/?l=linux-kernel&m=150575251328591
>
> I sent before.
>
> Looks like this code was always wrong, then 948b701a607f ("binfmt_misc: add persistent
> opened binary handler for containers") added more problems.
>
> Oleg.
>
>  fs/binfmt_misc.c | 56 ++++++++++++++++++++++++++------------------------------
>  1 file changed, 26 insertions(+), 30 deletions(-)

This all looks correct to me, thanks!

Acked-by: Kees Cook <keescook@chromium.org>

-Kees

-- 
Kees Cook
Pixel Security

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] exec: binfmt_misc: fix use-after-free, kill  iname[BINPRM_BUF_SIZE] Oleg Nesterov <oleg@redhat.com> - 2017-09-22 16:40 +0200
  [PATCH 1/5] exec: binfmt_misc: don't nullify Node->dentry in  kill_node() Oleg Nesterov <oleg@redhat.com> - 2017-09-22 16:40 +0200
  [PATCH 4/5] exec: binfmt_misc: fix race between load_misc_binary()  and kill_node() Oleg Nesterov <oleg@redhat.com> - 2017-09-22 16:40 +0200
  Re: [PATCH 0/5] exec: binfmt_misc: fix use-after-free, kill iname[BINPRM_BUF_SIZE] Kees Cook <keescook@chromium.org> - 2017-09-22 17:30 +0200

csiph-web