Re: [PATCH] pinctrl: intel: Mask interrupts on driver probe

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: intel: Mask interrupts on driver probe
Date	2017-09-22 15:40 +0200
Message-ID	<uswlr-6DX-17@gated-at.bofh.it> (permalink)
References	<usfkC-50V-15@gated-at.bofh.it> <usp0C-2io-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 22, 2017 at 7:47 AM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> On Thu, Sep 21, 2017 at 02:20:03PM -0500, Kyle Roeschley wrote:
>> Powering off the system on Apollo Lake does not clear the interrupt
>> enable registers for the GPIOs. To avoid an interrupt storm on driver
>> probe, clear all interrupt enables before enabling our interrupt line.
>
> It is up to the BIOS to set the proper mask and program the pads
> accordingly. Which platform and BIOS this is?
>
> I would rather not do this because it might cause other problems.

If this needs to happen llike this on some systems or even
just on some BIOS revisions the target systems and/or BIOS
revisions certainly need to be detected first.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: intel: Mask interrupts on driver probe Kyle Roeschley <kyle.roeschley@ni.com> - 2017-09-21 21:30 +0200
  Re: [PATCH] pinctrl: intel: Mask interrupts on driver probe Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-09-22 07:50 +0200
    Re: [PATCH] pinctrl: intel: Mask interrupts on driver probe Linus Walleij <linus.walleij@linaro.org> - 2017-09-22 15:40 +0200

csiph-web