Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1737527

Re: [RFC][PATCH] sched: Cleanup task->state printing

From Steven Rostedt <rostedt@goodmis.org>
Newsgroups linux.kernel
Subject Re: [RFC][PATCH] sched: Cleanup task->state printing
Date 2017-09-22 16:20 +0200
Message-ID <uswYa-75K-5@gated-at.bofh.it> (permalink)
References (3 earlier) <us7wL-cK-25@gated-at.bofh.it> <us8VP-Zu-17@gated-at.bofh.it> <usaXD-2gx-1@gated-at.bofh.it> <ussBc-4qH-17@gated-at.bofh.it> <usuMF-5Em-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Fri, 22 Sep 2017 13:54:30 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> I should probably split this thing into a bunch of patches :/

Yes please. Convert form dec to hex in one patch and one patch only.

Because I'm not sure if you meant to change numbers or not.


>  /* Used in tsk->state again: */
> -#define TASK_DEAD			64
> -#define TASK_WAKEKILL			128
> -#define TASK_WAKING			256
> -#define TASK_PARKED			512
> -#define TASK_NOLOAD			1024
> -#define TASK_NEW			2048
> -#define TASK_STATE_MAX			4096
> +#define TASK_PARKED			0x0040
> +#define TASK_REPORT_MAX			0x0080
>  
> -#define TASK_STATE_TO_CHAR_STR		"RSDTtXZxKWPNn"
> +/* Not in TASK_REPORT: */
> +#define TASK_DEAD			0x0080

TASK_DEAD went from 64 to 128 (0x40 to 0x80)

As well as all the defines below that. Was this on purpose?

> +#define TASK_WAKEKILL			0x0100
> +#define TASK_WAKING			0x0200
> +#define TASK_NOLOAD			0x0400
> +#define TASK_NEW			0x0800
> +
> +#define TASK_STATE_MAX			0x1000

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: Worker threads in D state since c5a94a618e7ac86 (workqueue: Use  TASK_IDLE) Tejun Heo <tj@kernel.org> - 2017-09-11 15:20 +0200
  Re: Worker threads in D state since c5a94a618e7ac86 (workqueue: Use  TASK_IDLE) Markus Trippelsdorf <markus@trippelsdorf.de> - 2017-09-11 16:30 +0200
    Re: Worker threads in D state since c5a94a618e7ac86 (workqueue: Use  TASK_IDLE) Markus Trippelsdorf <markus@trippelsdorf.de> - 2017-09-21 13:10 +0200
      Re: Worker threads in D state since c5a94a618e7ac86 (workqueue: Use  TASK_IDLE) Peter Zijlstra <peterz@infradead.org> - 2017-09-21 14:40 +0200
        Re: Worker threads in D state since c5a94a618e7ac86 (workqueue: Use  TASK_IDLE) Markus Trippelsdorf <markus@trippelsdorf.de> - 2017-09-21 16:50 +0200
          Re: Worker threads in D state since c5a94a618e7ac86 (workqueue: Use  TASK_IDLE) Markus Trippelsdorf <markus@trippelsdorf.de> - 2017-09-22 11:40 +0200
            [RFC][PATCH] sched: Cleanup task->state printing Peter Zijlstra <peterz@infradead.org> - 2017-09-22 14:00 +0200
              Re: [RFC][PATCH] sched: Cleanup task->state printing Markus Trippelsdorf <markus@trippelsdorf.de> - 2017-09-22 14:50 +0200
              Re: [RFC][PATCH] sched: Cleanup task->state printing Steven Rostedt <rostedt@goodmis.org> - 2017-09-22 16:20 +0200
                Re: [RFC][PATCH] sched: Cleanup task->state printing Peter Zijlstra <peterz@infradead.org> - 2017-09-22 18:00 +0200

csiph-web