Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1737429
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/4] [media] usbvision-core: Use common error handling code in usbvision_set_compress_params() |
| Date | 2017-09-22 13:50 +0200 |
| Message-ID | <usuD0-5Be-5@gated-at.bofh.it> (permalink) |
| References | <usbgZ-2CM-5@gated-at.bofh.it> <usbgZ-2CM-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Sep 21, 2017 at 05:07:06PM +0200, SF Markus Elfring wrote: > @@ -1913,11 +1908,12 @@ static int usbvision_set_compress_params(struct usb_usbvision *usbvision) > USB_DIR_OUT | USB_TYPE_VENDOR | > USB_RECIP_ENDPOINT, 0, > (__u16) USBVISION_PCM_THR1, value, 6, HZ); > + if (rc < 0) > +report_failure: > + dev_err(&usbvision->dev->dev, > + "%s: ERROR=%d. USBVISION stopped - reconnect or reload driver.\n", > + __func__, rc); You've been asked several times not to write code like this. You do it later in the patch series as well. regards, dan carpenter
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/4] [media] usbvision-core: Use common error handling code in usbvision_set_compress_params() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-21 17:10 +0200
Re: [PATCH 2/4] [media] usbvision-core: Use common error handling code in usbvision_set_compress_params() Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-22 13:50 +0200
Re: [PATCH 2/4] [media] usbvision-core: Use common error handling code in usbvision_set_compress_params() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-22 17:00 +0200
csiph-web