Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1737270

[PATCH 09/10] drivers: tty: sn_console: use setup_timer() helper.

From Allen Pais <allen.lkml@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 09/10] drivers: tty: sn_console: use setup_timer() helper.
Date 2017-09-22 10:30 +0200
Message-ID <usrvs-3Q3-27@gated-at.bofh.it> (permalink)
References <usrvs-3Q3-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


        Use setup_timer function instead of initializing timer with the
        function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/tty/serial/sn_console.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/tty/serial/sn_console.c b/drivers/tty/serial/sn_console.c
index 9e0e658..81d506d2 100644
--- a/drivers/tty/serial/sn_console.c
+++ b/drivers/tty/serial/sn_console.c
@@ -687,9 +687,7 @@ static void __init sn_sal_switch_to_asynch(struct sn_cons_port *port)
 	 * timer to poll for input and push data from the console
 	 * buffer.
 	 */
-	init_timer(&port->sc_timer);
-	port->sc_timer.function = sn_sal_timer_poll;
-	port->sc_timer.data = (unsigned long)port;
+	setup_timer(&port->sc_timer, sn_sal_timer_poll, (unsigned long)port);
 
 	if (IS_RUNNING_ON_SIMULATOR())
 		port->sc_interrupt_timeout = 6;
-- 
2.7.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 00/10] use setup_timer() helper function. Allen Pais <allen.lkml@gmail.com> - 2017-09-22 10:30 +0200
  [PATCH 01/10] drivers: tty: mux: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-22 10:30 +0200
  [PATCH 07/10] drivers: tty: sa1100: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-22 10:30 +0200
  [PATCH 09/10] drivers: tty: sn_console: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-22 10:30 +0200
  [PATCH 05/10] drivers: tty: pnx8xxx: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-22 10:30 +0200
  [PATCH 10/10] drivers: tty: ifx6x60: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-22 10:30 +0200
  [PATCH 08/10] drivers: tty: n_gsm: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-22 10:30 +0200

csiph-web