[PATCH] cpupower : Fix cpupower working when cpu0 is offline

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Abhishek Goel <huntbag@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	[PATCH] cpupower : Fix cpupower working when cpu0 is offline
Date	Fri, 22 Sep 2017 10:50:02 +0200
Message-ID	<usrOO-3W2-21@gated-at.bofh.it> (permalink)
X-Original-To	trenn@suse.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
X-Mailer	git-send-email 2.9.3
X-Tm-As-Mml	disable
X-Cbid	17092208-0008-0000-0000-000001587698
X-Ibm-Av-Detection	SAVI=unused REMOTE=unused XFE=unused
X-Cbparentid	17092208-0009-0000-0000-0000098DE5E9
X-Proofpoint-Virus-Version	vendor=fsecure engine=2.50.10432:,, definitions=2017-09-22_02:,, signatures=0
X-Proofpoint-Spam-Details	rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1709220122
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	Abhishek Goel <huntbag@linux.vnet.ibm.com>
X-Original-Date	Fri, 22 Sep 2017 14:17:32 +0530
X-Original-Message-ID	<20170922084732.119903-1-huntbag@linux.vnet.ibm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1737287

Show key headers only | View raw

cpuidle_monitor used to assume that cpu0 is always online. Now the
cpuidle_monitor function searches for the first online cpu and use
it, instead of always using cpu0 which maynot be online.

Signed-off-by: Abhishek Goel <huntbag@linux.vnet.ibm.com>
---
 tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c b/tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c
index 055a4fa..1cfba02 100644
--- a/tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c
+++ b/tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c
@@ -132,13 +132,13 @@ static struct cpuidle_monitor *cpuidle_register(void)
 	char *tmp;
 	int first_online_cpu;
 
-	for (num = 0; num < cpu_count; num++){
+	for (num = 0; num < cpu_count; num++) {
 		if (cpupower_is_cpu_online(num))
 			break;
 	};
 	first_online_cpu = num;
-	
-	/* Assume idle state count is the same for all CPUs */ 
+
+	/* Assume idle state count is the same for all CPUs */
 	cpuidle_sysfs_monitor.hw_states_num = cpuidle_state_count(first_online_cpu);
 
 	if (cpuidle_sysfs_monitor.hw_states_num <= 0)
-- 
2.9.3

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] cpupower : Fix cpupower working when cpu0 is offline Abhishek Goel <huntbag@linux.vnet.ibm.com> - 2017-09-22 10:50 +0200

csiph-web