Re: [PATCH net] net/ncsi: Don't assume last available channel exists

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net] net/ncsi: Don't assume last available channel exists
Date	2017-09-22 03:20 +0200
Message-ID	<uskNk-8fY-7@gated-at.bofh.it> (permalink)
References	<urEEp-6kH-1@gated-at.bofh.it> <urWhX-19i-7@gated-at.bofh.it> <uskDD-8cY-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Samuel Mendoza-Jonas <sam@mendozajonas.com>
Date: Fri, 22 Sep 2017 11:00:00 +1000

> If we haven't configured a channel yet (or are in the process of doing
> so) we won't have a hot_channel - does it make more sense to
> - check against the hot_channel as currently done,
> - only check the filter size at configure time for /each/ channel,
> - only conditionally enable the .ndo_vlan_rx_add_vid net_device callback
> once we've configured a channel (eg. for ftgmac100 in the
> ftgmac100_ncsi_handler() callback?)

The last isn't so feasible.

The device shouldn't be marked attached until a channel is available,
because it seems like communication cannot occur until one is.  Right?

You could experiment with netif_device_detach()/netif_device_attach().

When the device is in the detached state, callbacks such as
->ndo_vlan_rx_add_vid() will not be invoked.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net] net/ncsi: Don't assume last available channel exists Samuel Mendoza-Jonas <sam@mendozajonas.com> - 2017-09-20 06:20 +0200
  Re: [PATCH net] net/ncsi: Don't assume last available channel  exists David Miller <davem@davemloft.net> - 2017-09-21 01:10 +0200
    Re: [PATCH net] net/ncsi: Don't assume last available channel exists Samuel Mendoza-Jonas <sam@mendozajonas.com> - 2017-09-22 03:10 +0200
      Re: [PATCH net] net/ncsi: Don't assume last available channel  exists David Miller <davem@davemloft.net> - 2017-09-22 03:20 +0200

csiph-web