[PATCH] cnic: Fix an error handling path in 'cnic_alloc_bnx2x_resc()'

From	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Newsgroups	linux.kernel
Subject	[PATCH] cnic: Fix an error handling path in 'cnic_alloc_bnx2x_resc()'
Date	2017-09-22 01:10 +0200
Message-ID	<usiLv-77w-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

All the error handling paths 'goto error', except this one.
We should also go to error in this case, or some resources will be
leaking.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/net/ethernet/broadcom/cnic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/cnic.c b/drivers/net/ethernet/broadcom/cnic.c
index cec94bbb2ea5..8bc126a156e8 100644
--- a/drivers/net/ethernet/broadcom/cnic.c
+++ b/drivers/net/ethernet/broadcom/cnic.c
@@ -1278,7 +1278,7 @@ static int cnic_alloc_bnx2x_resc(struct cnic_dev *dev)
 
 	ret = cnic_alloc_dma(dev, kwq_16_dma, pages, 0);
 	if (ret)
-		return -ENOMEM;
+		goto error;
 
 	n = CNIC_PAGE_SIZE / CNIC_KWQ16_DATA_SIZE;
 	for (i = 0, j = 0; i < cp->max_cid_space; i++) {
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] cnic: Fix an error handling path in 'cnic_alloc_bnx2x_resc()' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-09-22 01:10 +0200
  Re: [PATCH] cnic: Fix an error handling path in  'cnic_alloc_bnx2x_resc()' David Miller <davem@davemloft.net> - 2017-09-24 02:20 +0200

csiph-web