Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1736905

[PATCH 58/64] drivers: net: packetengines: use setup_timer() helper.

From Allen Pais <allen.lkml@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 58/64] drivers: net: packetengines: use setup_timer() helper.
Date 2017-09-21 19:20 +0200
Message-ID <usdiO-3Se-17@gated-at.bofh.it> (permalink)
References <usd97-3OI-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

    Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/net/ethernet/packetengines/hamachi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/packetengines/hamachi.c b/drivers/net/ethernet/packetengines/hamachi.c
index 482b85e..77bc7cc 100644
--- a/drivers/net/ethernet/packetengines/hamachi.c
+++ b/drivers/net/ethernet/packetengines/hamachi.c
@@ -979,10 +979,8 @@ static int hamachi_open(struct net_device *dev)
 			   dev->name, readw(ioaddr + RxStatus), readw(ioaddr + TxStatus));
 	}
 	/* Set the timer to check for link beat. */
-	init_timer(&hmp->timer);
+	setup_timer(&hmp->timer, hamachi_timer, (unsigned long)dev);
 	hmp->timer.expires = RUN_AT((24*HZ)/10);			/* 2.4 sec. */
-	hmp->timer.data = (unsigned long)dev;
-	hmp->timer.function = hamachi_timer;				/* timer handler */
 	add_timer(&hmp->timer);
 
 	return 0;
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/64] use setup_timer() helper function. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 24/64] drivers: net: enic: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 16/64] drivers: net: tg3: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 15/64] drivers: net: sundance: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 12/64] drivers: net: atp: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 03/64] drivers: net: pcnet32: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 29/64] drivers: net: smsc: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 30/64] drivers: net: qlogic: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 35/64] drivers: net: can: usb: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 27/64] drivers: net: atmel: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 06/64] drivers: net: bcm63xx: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 07/64] drivers: net: declance: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 11/64] drivers: net: rsi_91x: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 05/64] drivers : net: niu: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 38/64] drivers: net: ath6kl: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 17/64] drivers: net: sdla: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 25/64] drivers: net: bnx2: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 19/64] drivers: net: slip: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 10/64] drivers: net: appletalk: cops: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 14/64] drivers: net: ixgb: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 20/64] drivers: net: spider_net: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 36/64] drivers: net: can: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 22/64] drivers: net: natsemi: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 01/64] drivers: net: de4x: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 33/64] drivers: net: amd8111e: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 28/64] drivers: net: hippi: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 13/64] drivers: net: ns83820: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 04/64] drivers: net: brcm80211: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 02/64] drivers: net: b44: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 31/64] drivers: net: e1000e: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 26/64] drivers: net: xen-netback: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 37/64] drivers: net: arcnet: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:10 +0200
  [PATCH 55/64] drivers: net: hamradio: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 40/64] drivers: net: sis900: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 42/64] drivers: net: mlx5: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 58/64] drivers: net: packetengines: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 56/64] drivers: net: cpsw_ale: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 60/64] drivers: net: uli526x: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 62/64] drivers: net: cxgb: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 43/64] drivers: net: mlx4: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 59/64] drivers: net: i40evf: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 39/64] drivers: net: sun: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 54/64] drivers: net: hdlc_ppp: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 52/64] drivers: net: appletalk: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 46/64] drivers: net: dmfe: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 51/64] drivers: net: caif: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 64/64] drivers: net: lmc: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 57/64] drivers: net: stmmac: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 49/64] drivers: net: adi: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 63/64] drivers: net: bnx2x: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 50/64] drivers: net: can: sja1000: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 61/64] drivers: net: enic: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 53/64] drivers: net: dscc: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 41/64] drivers: net: packetengines: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:20 +0200
  [PATCH 44/64] drivers: net: pxa168: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:30 +0200
  [PATCH 48/64] drivers: net: amd: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:30 +0200
  [PATCH 45/64] drivers: net: fealnx: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:30 +0200
  [PATCH 47/64] drivers: net: bnxt: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:30 +0200
  [PATCH 08/64] drivers: net: am79c961: use setup_timer() helper. Allen Pais <allen.lkml@gmail.com> - 2017-09-21 19:40 +0200
  Re: [PATCH 00/64] use setup_timer() helper function. David Miller <davem@davemloft.net> - 2017-09-21 20:40 +0200
    Re: [PATCH 00/64] use setup_timer() helper function. Allen <allen.lkml@gmail.com> - 2017-09-22 08:30 +0200

csiph-web