Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1736833

[PATCH -next] spi: fix spi-sprd-adi build errors when COMPILE_TEST=y

Show all headers | View raw

From: Randy Dunlap <rdunlap@infradead.org>

Fix build errors when CONFIG_HWSPINLOCK=m.

This patch fixes the build errors when COMPILE_TEST=y,
but I expect that this driver also wants HWSPINLOCK_SPRD=y (or =m
when SPI_SPRD_ADI=m).

drivers/spi/spi-sprd-adi.o: In function `sprd_adi_remove':
spi-sprd-adi.c:(.text+0x13): undefined reference to `hwspin_lock_free'
drivers/spi/spi-sprd-adi.o: In function `sprd_adi_probe':
spi-sprd-adi.c:(.text+0xf5): undefined reference to `of_hwspin_lock_get_id'
spi-sprd-adi.c:(.text+0x107): undefined reference to `hwspin_lock_request_specific'
spi-sprd-adi.c:(.text+0x22e): undefined reference to `hwspin_lock_free'
drivers/spi/spi-sprd-adi.o: In function `sprd_adi_transfer_one':
spi-sprd-adi.c:(.text+0x2eb): undefined reference to `__hwspin_lock_timeout'
spi-sprd-adi.c:(.text+0x349): undefined reference to `__hwspin_unlock'
spi-sprd-adi.c:(.text+0x389): undefined reference to `__hwspin_lock_timeout'
spi-sprd-adi.c:(.text+0x3ee): undefined reference to `__hwspin_unlock'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Baolin Wang <Baolin.Wang@spreadtrum.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org
---
 drivers/spi/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20170921.orig/drivers/spi/Kconfig
+++ linux-next-20170921/drivers/spi/Kconfig
@@ -625,6 +625,7 @@ config SPI_SIRF
 config SPI_SPRD_ADI
 	tristate "Spreadtrum ADI controller"
 	depends on ARCH_SPRD || COMPILE_TEST
+	depends on HWSPINLOCK
 	help
 	  ADI driver based on SPI for Spreadtrum SoCs.
 

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] spi: fix spi-sprd-adi build errors when COMPILE_TEST=y Randy Dunlap <rdunlap@infradead.org> - 2017-09-21 18:20 +0200
  Re: [PATCH -next] spi: fix spi-sprd-adi build errors when  COMPILE_TEST=y Mark Brown <broonie@kernel.org> - 2017-09-21 18:50 +0200
    Re: [PATCH -next] spi: fix spi-sprd-adi build errors when  COMPILE_TEST=y Randy Dunlap <rdunlap@infradead.org> - 2017-09-21 20:10 +0200

csiph-web