Re: [PATCH] ath10: mark PM functions as __maybe_unused

From	Kalle Valo <kvalo@qca.qualcomm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ath10: mark PM functions as __maybe_unused
Date	2017-09-21 17:10 +0200
Message-ID	<usbh0-2CM-21@gated-at.bofh.it> (permalink)
References	<umI5X-1TZ-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Arnd Bergmann <arnd@arndb.de> writes:

> When CONFIG_PM_SLEEP is disabled, we get a compile-time
> warning:
>
> drivers/net/wireless/ath/ath10k/pci.c:3417:12: error: 'ath10k_pci_pm_resume' defined but not used [-Werror=unused-function]
>  static int ath10k_pci_pm_resume(struct device *dev)
>             ^~~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/ath/ath10k/pci.c:3401:12: error: 'ath10k_pci_pm_suspend' defined but not used [-Werror=unused-function]
>  static int ath10k_pci_pm_suspend(struct device *dev)
>
> Rather than fixing the #ifdef, this just marks both functions
> as __maybe_unused, which is a more robust way to do this.
>
> Fixes: 32faa3f0ee50 ("ath10k: add the PCI PM core suspend/resume ops")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied to ath-current branch in ath.git, thanks.

(Having problems with my patchwork script so sending this manually)

-- 
Kalle Valo

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] ath10: mark PM functions as __maybe_unused Kalle Valo <kvalo@qca.qualcomm.com> - 2017-09-21 17:10 +0200

csiph-web