Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1736776
| From | "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH v2 1/2] membarrier: Provide register expedited private command |
| Date | 2017-09-21 17:30 +0200 |
| Message-ID | <usbAm-2Ne-21@gated-at.bofh.it> (permalink) |
| References | <urcRQ-47U-9@gated-at.bofh.it> <us8Cu-Sx-15@gated-at.bofh.it> <usbqG-2Ji-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Sep 21, 2017 at 03:11:43PM +0000, Mathieu Desnoyers wrote:
> ----- On Sep 21, 2017, at 8:13 AM, Peter Zijlstra peterz@infradead.org wrote:
>
> > On Mon, Sep 18, 2017 at 06:36:47PM -0400, Mathieu Desnoyers wrote:
> >> @@ -3373,6 +3362,7 @@ static void __sched notrace __schedule(bool preempt)
> >>
> >> /* Also unlocks the rq: */
> >> rq = context_switch(rq, prev, next, &rf);
> >> + membarrier_arch_sched_in(prev, next);
> >
> > That's wrong iirc; we just switched stacks, you cannot use @prev and
> > @next.
>
> Yes, it did indeed explode spectacularly at boot in testing. RFC v3 fixes that.
Good to hear that there is a useful test. ;-)
Thanx, Paul
> Thanks,
>
> Mathieu
>
>
> >
> >> } else {
> >> rq->clock_update_flags &= ~(RQCF_ACT_SKIP|RQCF_REQ_SKIP);
> > > rq_unlock_irq(rq, &rf);
>
> --
> Mathieu Desnoyers
> EfficiOS Inc.
> http://www.efficios.com
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH v2 1/2] membarrier: Provide register expedited private command Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2017-09-19 00:40 +0200
[RFC PATCH 2/2] membarrier: selftest: Test private expedited cmd Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2017-09-19 00:40 +0200
Re: [RFC PATCH v2 1/2] membarrier: Provide register expedited private command Peter Zijlstra <peterz@infradead.org> - 2017-09-21 14:20 +0200
Re: [RFC PATCH v2 1/2] membarrier: Provide register expedited private command Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2017-09-21 17:20 +0200
Re: [RFC PATCH v2 1/2] membarrier: Provide register expedited private command "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-09-21 17:30 +0200
Re: [RFC PATCH v2 1/2] membarrier: Provide register expedited private command Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2017-09-21 17:50 +0200
csiph-web