Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1738064
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 3/3] [media] camss-csid: Adjust a null pointer check in two functions |
| Date | 2017-09-23 21:50 +0200 |
| Message-ID | <usYB4-7fq-13@gated-at.bofh.it> (permalink) |
| References | <usYB4-7fq-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sat, 23 Sep 2017 21:10:02 +0200 The script "checkpatch.pl" pointed information out like the following. Comparison to NULL could be written "!format" Thus fix the affected source code places. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/media/platform/qcom/camss-8x16/camss-csid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/camss-8x16/camss-csid.c b/drivers/media/platform/qcom/camss-8x16/camss-csid.c index ffda0fbfe4d8..e546f97fa68c 100644 --- a/drivers/media/platform/qcom/camss-8x16/camss-csid.c +++ b/drivers/media/platform/qcom/camss-8x16/camss-csid.c @@ -653,4 +653,4 @@ static int csid_get_format(struct v4l2_subdev *sd, - if (format == NULL) + if (!format) return -EINVAL; fmt->format = *format; @@ -677,4 +677,4 @@ static int csid_set_format(struct v4l2_subdev *sd, - if (format == NULL) + if (!format) return -EINVAL; csid_try_format(csid, cfg, fmt->pad, &fmt->format, fmt->which); -- 2.14.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] [media] camss-csid: Fine-tuning for three function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-23 21:50 +0200 [PATCH 3/3] [media] camss-csid: Adjust a null pointer check in two functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-23 21:50 +0200 [PATCH 2/3] [media] camss-csid: Reduce the scope for a variable in csid_set_power() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-23 21:50 +0200
csiph-web