Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1738057

[PATCH] irqchip/gic-v3-its: Fix the incorrect BUG_ON in its_init_vpe_domain()

Path csiph.com!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Shanker Donthineni <shankerd@codeaurora.org>
Newsgroups linux.kernel
Subject [PATCH] irqchip/gic-v3-its: Fix the incorrect BUG_ON in its_init_vpe_domain()
Date Sat, 23 Sep 2017 21:00:02 +0200
Message-ID <usXOG-6GM-5@gated-at.bofh.it> (permalink)
X-Original-To Marc Zyngier <marc.zyngier@arm.com>, linux-kernel <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1506192622; bh=eZTNuiWxg3BkdM0BYZzCa3yYPbY8Va9Yw2tSufMl3cw=; h=From:To:Cc:Subject:Date:From; b=awgGEVJp79Fo1HwlcDBC6JO3r4Jori5ljupkrJPSSJ4gOa1qkEUoTC9qmur73DBJR SBLy4Fqt1CcmCrqolmpVxZBmbMAqOpYPnbQW1K0VcQGwh3jXDxheo216q5Q/mFx+Mg q+tiorU5t7IsIDcmaXZ6ujLf1G5kIThKeyNhcfRM=
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1506192622; bh=eZTNuiWxg3BkdM0BYZzCa3yYPbY8Va9Yw2tSufMl3cw=; h=From:To:Cc:Subject:Date:From; b=awgGEVJp79Fo1HwlcDBC6JO3r4Jori5ljupkrJPSSJ4gOa1qkEUoTC9qmur73DBJR SBLy4Fqt1CcmCrqolmpVxZBmbMAqOpYPnbQW1K0VcQGwh3jXDxheo216q5Q/mFx+Mg q+tiorU5t7IsIDcmaXZ6ujLf1G5kIThKeyNhcfRM=
Dmarc-Filter OpenDMARC Filter v1.3.2 smtp.codeaurora.org B391F602A8
Authentication-Results pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org
Authentication-Results pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=shankerd@codeaurora.org
X-Mailer git-send-email 1.9.1
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 27
Organization linux.* mail to news gateway
X-Original-Cc Thomas Gleixner <tglx@linutronix.de>, Jason Cooper <jason@lakedaemon.net>, Shanker Donthineni <shankerd@codeaurora.org>
X-Original-Date Sat, 23 Sep 2017 13:50:19 -0500
X-Original-Message-ID <1506192619-15503-1-git-send-email-shankerd@codeaurora.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1738057

Show key headers only | View raw


The driver probe path hits 'BUG_ON(entries != vpe_proxy.dev->nr_ites)'
on systems where it has VLPI capability, doesn't support direct LPI
feature and boot with a single CPU.

Relax the BUG_ON() condition to fix the issue.

Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
---
 drivers/irqchip/irq-gic-v3-its.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index e8d8934..e3a59f4 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -2851,7 +2851,7 @@ static int its_init_vpe_domain(void)
 		return -ENOMEM;
 	}
 
-	BUG_ON(entries != vpe_proxy.dev->nr_ites);
+	BUG_ON(entries > vpe_proxy.dev->nr_ites);
 
 	raw_spin_lock_init(&vpe_proxy.lock);
 	vpe_proxy.next_victim = 0;
-- 
Qualcomm Datacenter Technologies, Inc. on behalf of the Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH] irqchip/gic-v3-its: Fix the incorrect BUG_ON in its_init_vpe_domain() Shanker Donthineni <shankerd@codeaurora.org> - 2017-09-23 21:00 +0200

csiph-web