Re: [PATCH] mm/device-public-memory: Fix edge case in _vm_normal_page()

Path	csiph.com!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From	Balbir Singh <bsingharora@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm/device-public-memory: Fix edge case in _vm_normal_page()
Date	Sat, 23 Sep 2017 08:10:01 +0200
Message-ID	<usLNv-7Vv-9@gated-at.bofh.it> (permalink)
References	<usxAR-7iO-1@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=BqLbzplKcdsCx+gQguZVE7Ox8KZ8nZoilBn0r509aJE=; b=W8NetmIMLUvA1n2Hcjb89gwzE/d4QkF8Xaz63CjcpPCHMAc3DaTDODm+HwAeI1ES3n omiSn0hyxcTwJfy0Gxt4TnHoc/xdlbI5wUut6gIRBVzrRuHWgHdZgNi1YC0iVMG9OAUO FFpb6IINlkRDIDTCLdamDO6C3WCWGWkJDSG1EZTYNE5WT+jecRbZc+hMmZ6ld0PPaTpl +fpdEHq2pvdTyzXM9/Bq7iYN/+wNI7xZkWUXLB6K2KkpTp8dCRqnxCdTwjS8BNlHDR72 cyS1G9ABxqtrmDdthk9jP3NiKTNwU55mb4qhC1c83y85bEAhsDvXp3vvMe2l9nIzu579 mtzg==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BqLbzplKcdsCx+gQguZVE7Ox8KZ8nZoilBn0r509aJE=; b=cCO0Q5k21ePprq+fWrUNE+GVcFB3jpjfTr3f/bxoIGqf1kUbVlShckRdC6czXfFWj8 nVBiXqVL1M6SMoVeD48reNp7pDeW2JiC1iljVWEaviTPvgNO8bS6nsfNXUqB7i7+YoGe rA+j/gHpOEfdpzwwAcUK6P6UEq66DlEg1aobI/Q6yPPRbtm/Z8QOkaij3Zj5zOxGANnJ cAdjcZPh9diDc4mRAe9ZMNkXyzfxmQjrOkzxduww5wDzg/5jdTsum5wtgbERKtgKNVwg 8GS+pWDkuuAFZG/BYjrKrafU8NuOaDDNiI/xbqEx7AmesRUpPlQ0S5VC9HnG5cKfss25 p6QA==
X-Gm-Message-State	AHPjjUiQHWbs9fRA8lSsm1jjT4axphWH0Uz86H95UXoXvAP2UV19NqCZ 09XbcSVh/RojVXhg/tbVuwf9WA8Sb/69mfCcSbw=
X-Google-SMTP-Source	AOwi7QC7rgPw9nLfrvN1nmjMVccXHXfzlcF62rOqUBn7ZvH8CQJUcdcelnoEJOQq87QJafAGRLCJNKja6u/hmhhAVmQ=
X-Received	by 10.159.34.132 with SMTP id 4mr1283654uan.99.1506146471233; Fri, 22 Sep 2017 23:01:11 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset="UTF-8"
Content-Transfer-Encoding	quoted-printable
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	Andrew Morton <akpm@linux-foundation.org>, linux-mm <linux-mm@kvack.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Jérôme Glisse <jglisse@redhat.com>
X-Original-Date	Sat, 23 Sep 2017 16:01:10 +1000
X-Original-Message-ID	<CAKTCnzk6k3q8Pkh=REVFuiXuf=faORziwUBSkq_eOchM7J1BHA@mail.gmail.com>
X-Original-References	<1506092178-20351-1-git-send-email-arbab@linux.vnet.ibm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1737966

Show key headers only | View raw

On Sat, Sep 23, 2017 at 12:56 AM, Reza Arbab <arbab@linux.vnet.ibm.com> wrote:
> With device public pages at the end of my memory space, I'm getting
> output from _vm_normal_page():
>
> BUG: Bad page map in process migrate_pages  pte:c0800001ffff0d06 pmd:f95d3000
> addr:00007fff89330000 vm_flags:00100073 anon_vma:c0000000fa899320 mapping:          (null) index:7fff8933
> file:          (null) fault:          (null) mmap:          (null) readpage:          (null)
> CPU: 0 PID: 13963 Comm: migrate_pages Tainted: P    B      OE 4.14.0-rc1-wip #155
> Call Trace:
> [c0000000f965f910] [c00000000094d55c] dump_stack+0xb0/0xf4 (unreliable)
> [c0000000f965f950] [c0000000002b269c] print_bad_pte+0x28c/0x340
> [c0000000f965fa00] [c0000000002b59c0] _vm_normal_page+0xc0/0x140
> [c0000000f965fa20] [c0000000002b6e64] zap_pte_range+0x664/0xc10
> [c0000000f965fb00] [c0000000002b7858] unmap_page_range+0x318/0x670
> [c0000000f965fbd0] [c0000000002b8074] unmap_vmas+0x74/0xe0
> [c0000000f965fc20] [c0000000002c4a18] exit_mmap+0xe8/0x1f0
> [c0000000f965fce0] [c0000000000ecbdc] mmput+0xac/0x1f0
> [c0000000f965fd10] [c0000000000f62e8] do_exit+0x348/0xcd0
> [c0000000f965fdd0] [c0000000000f6d2c] do_group_exit+0x5c/0xf0
> [c0000000f965fe10] [c0000000000f6ddc] SyS_exit_group+0x1c/0x20
> [c0000000f965fe30] [c00000000000b184] system_call+0x58/0x6c
>
> The pfn causing this is the very last one. Correct the bounds check
> accordingly.
>
> Fixes: df6ad69838fc ("mm/device-public-memory: device memory cache coherent with CPU")
> Cc: Jérôme Glisse <jglisse@redhat.com>
> Signed-off-by: Reza Arbab <arbab@linux.vnet.ibm.com>
> ---

Reviewed-by: Balbir Singh <bsingharora@gmail.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mm/device-public-memory: Fix edge case in _vm_normal_page() Reza Arbab <arbab@linux.vnet.ibm.com> - 2017-09-22 17:00 +0200
  Re: [PATCH] mm/device-public-memory: Fix edge case in  _vm_normal_page() Jerome Glisse <jglisse@redhat.com> - 2017-09-22 18:30 +0200
  Re: [PATCH] mm/device-public-memory: Fix edge case in _vm_normal_page() Balbir Singh <bsingharora@gmail.com> - 2017-09-23 08:10 +0200

csiph-web