Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1737956
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 03/12] ARM: dts: sunxi: h3/h5: Fix node with unit name and no reg property |
| Date | 2017-09-23 04:00 +0200 |
| Message-ID | <usHTz-5by-5@gated-at.bofh.it> (permalink) |
| References | <usBbr-16M-5@gated-at.bofh.it> <usBbr-16M-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Sep 23, 2017 at 2:40 AM, Corentin Labbe
<clabbe.montjoie@gmail.com> wrote:
> This patch fix the warning "xxx has a unit name, but no reg property" by
> removing "@0" from such node.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> arch/arm/boot/dts/sunxi-h3-h5.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> index 289f2cd06dfe..2e4bae988acd 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> @@ -322,7 +322,7 @@
> function = "i2c2";
> };
>
> - mmc0_pins_a: mmc0@0 {
> + mmc0_pins_a: mmc0 {
All pinmux nodes should have the suffix "_pins" or "_pin".
In the case where there are multiple choices, the node name should convey
what or which pingroup the choice is. In this case the name should be
"mmc0_pf_pins".
> pins = "PF0", "PF1", "PF2", "PF3",
> "PF4", "PF5";
> function = "mmc0";
> @@ -330,13 +330,13 @@
> bias-pull-up;
> };
>
> - mmc0_cd_pin: mmc0_cd_pin@0 {
> + mmc0_cd_pin: mmc0_cd_pin {
> pins = "PF6";
> function = "gpio_in";
> bias-pull-up;
> };
>
> - mmc1_pins_a: mmc1@0 {
> + mmc1_pins_a: mmc1 {
mmc1_pins
> pins = "PG0", "PG1", "PG2", "PG3",
> "PG4", "PG5";
> function = "mmc1";
> @@ -354,7 +354,7 @@
> bias-pull-up;
> };
>
> - spdif_tx_pins_a: spdif@0 {
> + spdif_tx_pins_a: spdif {
spdif_pin
> pins = "PA17";
> function = "spdif";
> };
> @@ -369,7 +369,7 @@
> function = "spi1";
> };
>
> - uart0_pins_a: uart0@0 {
> + uart0_pins_a: uart0 {
uart0_pb_pins
> pins = "PA4", "PA5";
> function = "uart0";
> };
> @@ -697,7 +697,7 @@
> interrupt-controller;
> #interrupt-cells = <3>;
>
> - ir_pins_a: ir@0 {
> + ir_pins_a: ir {
ir_pin
ChenYu
> pins = "PL11";
> function = "s_cir_rx";
> };
> --
> 2.13.5
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 00/12] ARM: dts: sunxi: Fix DT build warnings Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-22 20:50 +0200
[PATCH v2 03/12] ARM: dts: sunxi: h3/h5: Fix node with unit name and no reg property Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-22 20:50 +0200
Re: [PATCH v2 03/12] ARM: dts: sunxi: h3/h5: Fix node with unit name and no reg property Chen-Yu Tsai <wens@csie.org> - 2017-09-23 04:00 +0200
[PATCH v2 05/12] ARM: dts: orangepi2: Fix node with unit name and no reg property Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-22 20:50 +0200
[PATCH v2 02/12] ARM: dts: sunxi: h3/h5: Fix i2c2 register address Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-22 20:50 +0200
[PATCH v2 10/12] arm64: allwinner: a64: Fix simple-bus unit address format error Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-22 20:50 +0200
[PATCH v2 06/12] ARM: dts: sun8i: orangepi-lite: Fix node with unit name and no reg property Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-22 20:50 +0200
[PATCH v2 08/12] ARM: dts: sun8i: orangepipc: Fix node with unit name and no reg property Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-22 20:50 +0200
[PATCH v2 01/12] ARM: dts: sunxi: h3/h5: Fix simple-bus unit address format error Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-22 20:50 +0200
[PATCH v2 07/12] ARM: dts: sun8i: orangepi one: Fix node with unit name and no reg property Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-22 20:50 +0200
[PATCH v2 11/12] arm64: allwinner: a64: Fix node with unit name and no reg property Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-22 20:50 +0200
Re: [PATCH v2 11/12] arm64: allwinner: a64: Fix node with unit name and no reg property Chen-Yu Tsai <wens@csie.org> - 2017-09-23 04:40 +0200
[PATCH v2 04/12] ARM: dts: nanopi: Fix node with unit name and no reg property Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-22 20:50 +0200
[PATCH v2 12/12] ARM: dts: sun8i: a83t: Fix simple-bus unit address format error Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-22 20:50 +0200
[PATCH v2 09/12] ARM: dts: sun8i: orangepi-plus: Fix node with unit name and no reg property Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-22 20:50 +0200
csiph-web