Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1737934

Re: [PATCH] Asus WMI : Add lightbar led support

Show all headers | View raw

On Thu, Sep 21, 2017 at 01:20:01PM +0200, Maxime Bellengé wrote:
> Some asus laptops (ROG series for example) are provided with a lightbar behind the monitor.
> This patch make posible to switch it on and off. This lightbar works exactly as any other led.
> 

Hi Maxime,

The patch looks good from a functional implementation perspective.

There are 3 mechanical and style errors the checkpatch script catches. Please
update the patch and resubmit:

WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#85: 
Some asus laptops (ROG series for example) are provided with a lightbar behind the monitor.

WARNING: 'posible' may be misspelled - perhaps 'possible'?
#86: 
This patch make posible to switch it on and off. This lightbar works exactly as any other led.

WARNING: please, no space before tabs
#101: FILE: drivers/platform/x86/asus-wmi.c:122:
+#define ASUS_WMI_DEVID_LIGHTBAR ^I0x00050025$

total: 0 errors, 3 warnings, 103 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/home/dvhart/incoming/PATCH_Asus_WMI_Add_lightbar_led_support.mbox has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

-- 
Darren Hart
VMware Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Asus WMI : Add lightbar led support Maxime Bellengé <maxime.bellenge@gmail.com> - 2017-09-21 13:30 +0200
  Re: [PATCH] Asus WMI : Add lightbar led support Darren Hart <dvhart@infradead.org> - 2017-09-23 02:20 +0200

csiph-web