Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1737725

Re: [PATCH] auxdisplay: fix broken menus

Show all headers | View raw

Hi Randy,

On Fri, Sep 22, 2017 at 6:24 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Having the CHARLCD Kconfig symbol between "menuconfig AUXDISPLAY"
> and "if AUXDISPLAY" breaks the AUXDISPLAY submenus, so move the
> CHARLCD Kconfig symbol above the "menuconfig" so that the menu
> display is continuous.
>
> Fixes: 39f8ea46724e (auxdisplay: charlcd: Extract character LCD core from misc/panel)

Oops, sorry for that.

> Cc: stable@vger.kernel.org # v4.12
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
>  drivers/auxdisplay/Kconfig |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- lnx-414-rc1.orig/drivers/auxdisplay/Kconfig
> +++ lnx-414-rc1/drivers/auxdisplay/Kconfig
> @@ -5,6 +5,9 @@
>  # Auxiliary display drivers configuration.
>  #
>
> +config CHARLCD
> +       tristate "Character LCD core support" if COMPILE_TEST
> +

What about moving it inside (i.e. right below) the "if AUXDISPLAY" instead?

>  menuconfig AUXDISPLAY
>         bool "Auxiliary Display support"
>         ---help---
> @@ -13,9 +16,6 @@ menuconfig AUXDISPLAY
>
>           If you say N, all options in this submenu will be skipped and disabled.
>
> -config CHARLCD
> -       tristate "Character LCD core support" if COMPILE_TEST
> -
>  if AUXDISPLAY
>
>  config HD44780

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] auxdisplay: fix broken menus Randy Dunlap <rdunlap@infradead.org> - 2017-09-22 18:30 +0200
  Re: [PATCH] auxdisplay: fix broken menus Geert Uytterhoeven <geert@linux-m68k.org> - 2017-09-22 20:20 +0200
    Re: [PATCH] auxdisplay: fix broken menus Randy Dunlap <rdunlap@infradead.org> - 2017-09-22 20:30 +0200
      Re: [PATCH] auxdisplay: fix broken menus Geert Uytterhoeven <geert@linux-m68k.org> - 2017-09-22 21:50 +0200
        Re: [PATCH] auxdisplay: fix broken menus Randy Dunlap <rdunlap@infradead.org> - 2017-09-22 22:10 +0200
          Re: [PATCH] auxdisplay: fix broken menus Geert Uytterhoeven <geert@linux-m68k.org> - 2017-09-22 22:20 +0200
            Re: [PATCH] auxdisplay: fix broken menus Randy Dunlap <rdunlap@infradead.org> - 2017-09-22 22:50 +0200

csiph-web