Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1736626
| From | Allen <allen.lkml@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/1] drivers:usb: use setup_timer |
| Date | 2017-09-21 14:40 +0200 |
| Message-ID | <us8VP-Zu-9@gated-at.bofh.it> (permalink) |
| References | <us7Q7-kv-29@gated-at.bofh.it> <us8VP-Zu-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
>
> subject should've been something like:
>
> usb: gadget: udc: omap: use setup_timer() helper
>
> Also, you should've Cced linux-usb@vger.kernel.org and
> linux-omap@vger.kernel.org
>
> On Thu, Sep 21, 2017 at 2:28 PM Allen Pais <allen.lkml@gmail.com> wrote:
>>
>> Use setup_timer function instead of initializing timer with the
>> function and data fields.
>
>
> the spaces a the beginning of each line are pointless, please remove.
>
> Other than that, patch looks good. Please fix these details and resend.
>
Sure.
--
- Allen
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 1/1] drivers:usb: use setup_timer Allen Pais <allen.lkml@gmail.com> - 2017-09-21 13:30 +0200 Re: [PATCH 1/1] drivers:usb: use setup_timer Allen <allen.lkml@gmail.com> - 2017-09-21 14:40 +0200
csiph-web