Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1736537

Re: [PATCH RESEND 1/2] phy: phy-mtk-tphy: fix NULL point of chip bank

Show all headers | View raw

On Thursday 21 September 2017 04:01 PM, Chunfeng Yun wrote:
> Chip bank of version-1 is initialized as NULL, but it's used
> by pcie_phy_instance_power_on/off(), so assign it a right
> address.

merged. How was this not noticed before?

Thanks
Kishon
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
>  drivers/phy/mediatek/phy-mtk-tphy.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c b/drivers/phy/mediatek/phy-mtk-tphy.c
> index e3baad7..721a2a1 100644
> --- a/drivers/phy/mediatek/phy-mtk-tphy.c
> +++ b/drivers/phy/mediatek/phy-mtk-tphy.c
> @@ -27,6 +27,7 @@
>  /* banks shared by multiple phys */
>  #define SSUSB_SIFSLV_V1_SPLLC		0x000	/* shared by u3 phys */
>  #define SSUSB_SIFSLV_V1_U2FREQ		0x100	/* shared by u2 phys */
> +#define SSUSB_SIFSLV_V1_CHIP		0x300	/* shared by u3 phys */
>  /* u2 phy bank */
>  #define SSUSB_SIFSLV_V1_U2PHY_COM	0x000
>  /* u3/pcie/sata phy banks */
> @@ -762,7 +763,7 @@ static void phy_v1_banks_init(struct mtk_tphy *tphy,
>  	case PHY_TYPE_USB3:
>  	case PHY_TYPE_PCIE:
>  		u3_banks->spllc = tphy->sif_base + SSUSB_SIFSLV_V1_SPLLC;
> -		u3_banks->chip = NULL;
> +		u3_banks->chip = tphy->sif_base + SSUSB_SIFSLV_V1_CHIP;
>  		u3_banks->phyd = instance->port_base + SSUSB_SIFSLV_V1_U3PHYD;
>  		u3_banks->phya = instance->port_base + SSUSB_SIFSLV_V1_U3PHYA;
>  		break;
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RESEND 1/2] phy: phy-mtk-tphy: fix NULL point of chip bank Chunfeng Yun <chunfeng.yun@mediatek.com> - 2017-09-21 12:40 +0200
  Re: [PATCH RESEND 1/2] phy: phy-mtk-tphy: fix NULL point of chip bank Kishon Vijay Abraham I <kishon@ti.com> - 2017-09-21 13:00 +0200
    Re: [PATCH RESEND 1/2] phy: phy-mtk-tphy: fix NULL point of chip  bank Chunfeng Yun <chunfeng.yun@mediatek.com> - 2017-09-22 03:20 +0200

csiph-web