Re: [PATCH][pinctrl-next] pinctrl/amd: make functions amd_gpio_suspend and amd_gpio_resume static

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH][pinctrl-next] pinctrl/amd: make functions amd_gpio_suspend and amd_gpio_resume static
Date	2017-09-21 13:40 +0200
Message-ID	<us7ZN-o2-27@gated-at.bofh.it> (permalink)
References	<upiym-1dH-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 13, 2017 at 6:15 PM, Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
>
> The functions amd_gpio_suspend and amd_gpio_resume are local to the
> source and do not need to be in global scope, so make them static.
>
> Cleans up sparse warnings:
> symbol 'amd_gpio_suspend' was not declared. Should it be static?
> symbol 'amd_gpio_resume' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch applied with Daniel's review tag.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH][pinctrl-next] pinctrl/amd: make functions amd_gpio_suspend and amd_gpio_resume static Colin King <colin.king@canonical.com> - 2017-09-13 18:20 +0200
  Re: [PATCH][pinctrl-next] pinctrl/amd: make functions  amd_gpio_suspend and amd_gpio_resume static Daniel Drake <drake@endlessm.com> - 2017-09-14 01:40 +0200
  Re: [PATCH][pinctrl-next] pinctrl/amd: make functions  amd_gpio_suspend and amd_gpio_resume static Linus Walleij <linus.walleij@linaro.org> - 2017-09-21 13:40 +0200

csiph-web