Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1736573
| From | Ville Syrjälä <ville.syrjala@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] drm: tegra: dc: Handle return value of kasprintf |
| Date | 2017-09-21 13:30 +0200 |
| Message-ID | <us7Q7-kv-43@gated-at.bofh.it> (permalink) |
| References | <urHCi-8iH-19@gated-at.bofh.it> <urHCi-8iH-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Sep 20, 2017 at 12:55:07PM +0530, Arvind Yadav wrote: > kasprintf() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > drivers/gpu/drm/tegra/dc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c > index 4df3911..f3214a1 100644 > --- a/drivers/gpu/drm/tegra/dc.c > +++ b/drivers/gpu/drm/tegra/dc.c > @@ -1695,6 +1695,8 @@ static int tegra_dc_debugfs_init(struct tegra_dc *dc, struct drm_minor *minor) > int err; > > name = kasprintf(GFP_KERNEL, "dc.%d", dc->pipe); > + if (!name) > + return -ENOMEM; > dc->debugfs = debugfs_create_dir(name, minor->debugfs_root); Indeed, doesn't look like debugfs_create_dir() can be safely called w/ name==NULL. Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > kfree(name); > > -- > 1.9.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel OTC
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] Handle / Release memory obtained by kasprintf Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-20 09:30 +0200
[PATCH 1/2] drm: tegra: dc: Handle return value of kasprintf Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-20 09:30 +0200
Re: [PATCH 1/2] drm: tegra: dc: Handle return value of kasprintf Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-09-21 13:30 +0200
[PATCH 2/2] drm: Release memory obtained by kasprintf Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-20 09:30 +0200
Re: [PATCH 2/2] drm: Release memory obtained by kasprintf Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-09-21 13:30 +0200
csiph-web