Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1736560

[PATCH] net: phy: Fix truncation of large IRQ numbers in phy_attached_print()

Show all headers | View raw

Given NR_IRQS is 2048 on sparc64, and even 32784 on alpha, 3 digits is
not enough to represent interrupt numbers on all architectures.  Hence
PHY interrupt numbers may be truncated during printing.

Increase the buffer size from 4 to 8 bytes to fix this.

Fixes: 5e369aefdce4818c ("net: stmmac: Delete dead code for MDIO registration")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/net/phy/phy_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 8cf0c5901f95870f..67f25ac29025c539 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -879,7 +879,7 @@ void phy_attached_print(struct phy_device *phydev, const char *fmt, ...)
 {
 	const char *drv_name = phydev->drv ? phydev->drv->name : "unbound";
 	char *irq_str;
-	char irq_num[4];
+	char irq_num[8];
 
 	switch(phydev->irq) {
 	case PHY_POLL:
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: phy: Fix truncation of large IRQ numbers in phy_attached_print() Geert Uytterhoeven <geert+renesas@glider.be> - 2017-09-21 13:30 +0200
  Re: [PATCH] net: phy: Fix truncation of large IRQ numbers in  phy_attached_print() Andrew Lunn <andrew@lunn.ch> - 2017-09-21 17:50 +0200
  Re: [PATCH] net: phy: Fix truncation of large IRQ numbers in  phy_attached_print() David Miller <davem@davemloft.net> - 2017-09-22 05:40 +0200

csiph-web