Re: [PATCH] rtc: interface: set the next alarm event appropriately

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] rtc: interface: set the next alarm event appropriately
Date	2017-09-21 11:00 +0200
Message-ID	<us5uV-71k-1@gated-at.bofh.it> (permalink)
References	<urDS1-5Mi-9@gated-at.bofh.it> <urJkJ-11L-5@gated-at.bofh.it> <us3t8-5H4-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 21/09/2017 at 14:45:17 +0800, YiPing Xu wrote:
> 
> 
> On 2017/9/20 17:16, Alexandre Belloni wrote:
> > Hi,
> > 
> > On 20/09/2017 at 11:22:31 +0800, Xu Yiping wrote:
> > > From: Xu YiPing  <xuyiping@hisilicon.com>
> > > 
> > > After commit 2b2f5ff00f63 ("rtc: interface: ignore expired timers when
> > > enqueuing new timers"), the rtc_timer_enqueue will not reprogram the RTC
> > > when there is any non-expired timers in the timerqueue. If we set a
> > > RTC_TIMER between now and the next non-expired timers, it won't go into
> > > effect in time.
> > > 
> > > So, besides ignoring the expired timers, we should take the next effect
> > > timer into account, and reprogram the RTC timer appropriately.
> > > 
> > 
> > Can you try this patch instead? I think it solves this issue:
> > http://patchwork.ozlabs.org/patch/792482/
> 
>    We've tested this patch, it works too.
> 
>    Will it be merged into the main tree?
> 

Yes, I will send it as a fix for 4.14.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] rtc: interface: set the next alarm event appropriately Xu Yiping <xuyiping@hisilicon.com> - 2017-09-20 05:30 +0200
  Re: [PATCH] rtc: interface: set the next alarm event appropriately Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-09-20 11:20 +0200
    Re: [PATCH] rtc: interface: set the next alarm event appropriately YiPing Xu <xuyiping@hisilicon.com> - 2017-09-20 11:40 +0200
    Re: [PATCH] rtc: interface: set the next alarm event appropriately YiPing Xu <xuyiping@hisilicon.com> - 2017-09-21 08:50 +0200
      Re: [PATCH] rtc: interface: set the next alarm event appropriately Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-09-21 11:00 +0200

csiph-web