Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1736408

[PATCH 4/4] ALSA: emu10k1: Cocci spatch "alloc_cast"

From Thomas Meyer <thomas@m3y3r.de>
Newsgroups linux.kernel
Subject [PATCH 4/4] ALSA: emu10k1: Cocci spatch "alloc_cast"
Date 2017-09-21 08:50 +0200
Message-ID <us3t8-5H4-17@gated-at.bofh.it> (permalink)
References <us3t7-5H4-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Remove casting the values returned by memory allocation functions like
kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc."
Found by coccinelle spatch "api/alloc/alloc_cast.cocci"

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---

diff -u -p a/sound/pci/emu10k1/emufx.c b/sound/pci/emu10k1/emufx.c
--- a/sound/pci/emu10k1/emufx.c
+++ b/sound/pci/emu10k1/emufx.c
@@ -1218,7 +1218,7 @@ static int _snd_emu10k1_audigy_init_efx(
 	if (!icode)
 		return err;
 
-	icode->gpr_map = (u_int32_t __user *) kcalloc(512 + 256 + 256 + 2 * 1024,
+	icode->gpr_map = kcalloc(512 + 256 + 256 + 2 * 1024,
 						      sizeof(u_int32_t), GFP_KERNEL);
 	if (!icode->gpr_map)
 		goto __err_gpr;
@@ -1853,7 +1853,7 @@ static int _snd_emu10k1_init_efx(struct
 	if (!icode)
 		return err;
 
-	icode->gpr_map = (u_int32_t __user *) kcalloc(256 + 160 + 160 + 2 * 512,
+	icode->gpr_map = kcalloc(256 + 160 + 160 + 2 * 512,
 						      sizeof(u_int32_t), GFP_KERNEL);
 	if (!icode->gpr_map)
 		goto __err_gpr;

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH 4/4] ALSA: emu10k1: Cocci spatch "alloc_cast" Thomas Meyer <thomas@m3y3r.de> - 2017-09-21 08:50 +0200
  Re: [PATCH 4/4] ALSA: emu10k1: Cocci spatch "alloc_cast" Takashi Iwai <tiwai@suse.de> - 2017-09-21 10:10 +0200
  Re: [PATCH 4/4] ALSA: emu10k1: Cocci spatch "alloc_cast" Al Viro <viro@ZenIV.linux.org.uk> - 2017-09-21 19:40 +0200
    Re: [PATCH 4/4] ALSA: emu10k1: Cocci spatch "alloc_cast" Takashi Iwai <tiwai@suse.de> - 2017-09-21 22:40 +0200

csiph-web