[PATCH] staging:ccree Fix char * array declaration

From	Janani Sankara Babu <jananis37@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] staging:ccree Fix char * array declaration
Date	2017-09-21 08:50 +0200
Message-ID	<us3t7-5H4-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

This patch solves the following warning shown by the checkpatch script
Warning: char * array declaration might be better as static const

Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
---
 drivers/staging/ccree/ssi_sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ccree/ssi_sysfs.c b/drivers/staging/ccree/ssi_sysfs.c
index dbcd163..87cef46 100644
--- a/drivers/staging/ccree/ssi_sysfs.c
+++ b/drivers/staging/ccree/ssi_sysfs.c
@@ -300,7 +300,7 @@ static ssize_t ssi_sys_regdump_show(struct kobject *kobj,
 static ssize_t ssi_sys_help_show(struct kobject *kobj,
 		struct kobj_attribute *attr, char *buf)
 {
-	char *help_str[] = {
+	static const char *help_str[] = {
 				"cat reg_dump              ", "Print several of CC register values",
 		#if defined CC_CYCLE_COUNT
 				"cat stats_host            ", "Print host statistics",
-- 
1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] staging:ccree Fix char * array declaration Janani Sankara Babu <jananis37@gmail.com> - 2017-09-21 08:50 +0200

csiph-web