Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1736362

Re: [PATCH] nvme: make controller 'state' sysfs attribute pollable

Show all headers | View raw

On Wed, Sep 20, 2017 at 04:59:31PM +0200, Christoph Hellwig wrote:
> On Wed, Sep 20, 2017 at 12:40:32PM +0200, Johannes Thumshirn wrote:
> > Notify sysfs about changes of a nvme controller so user-space can watch the
> > file via poll() or select() in order to react to a state change.
> 
> Userspace has no business polling for the state.

So why exposing it then in the first time? I know you don't want dm-mpath in
NVMe (neither do I) but we have to have something until your patchset and ANA
is merged. And with this patch it's trivial to build a path checker that just
looks at the state attribute in sysfs.

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] nvme: make controller 'state' sysfs attribute pollable Johannes Thumshirn <jthumshirn@suse.de> - 2017-09-20 12:50 +0200
  Re: [PATCH] nvme: make controller 'state' sysfs attribute pollable Sagi Grimberg <sagi@grimberg.me> - 2017-09-20 12:50 +0200
  Re: [PATCH] nvme: make controller 'state' sysfs attribute pollable Christoph Hellwig <hch@lst.de> - 2017-09-20 17:00 +0200
    Re: [PATCH] nvme: make controller 'state' sysfs attribute pollable Johannes Thumshirn <jthumshirn@suse.de> - 2017-09-21 07:20 +0200
      Re: [PATCH] nvme: make controller 'state' sysfs attribute pollable Christoph Hellwig <hch@lst.de> - 2017-09-21 16:20 +0200
      Re: [PATCH] nvme: make controller 'state' sysfs attribute pollable Sagi Grimberg <sagi@grimberg.me> - 2017-09-25 07:40 +0200
        Re: [PATCH] nvme: make controller 'state' sysfs attribute pollable Hannes Reinecke <hare@suse.de> - 2017-09-25 08:00 +0200
          Re: [PATCH] nvme: make controller 'state' sysfs attribute pollable Sagi Grimberg <sagi@grimberg.me> - 2017-09-25 09:10 +0200
            Re: [PATCH] nvme: make controller 'state' sysfs attribute pollable Hannes Reinecke <hare@suse.de> - 2017-09-25 10:30 +0200
              Re: [PATCH] nvme: make controller 'state' sysfs attribute pollable Christoph Hellwig <hch@lst.de> - 2017-09-25 15:00 +0200
    Re: [PATCH] nvme: make controller 'state' sysfs attribute pollable Guan Junxiong <guanjunxiong@huawei.com> - 2017-09-21 14:50 +0200
      Re: [PATCH] nvme: make controller 'state' sysfs attribute pollable Sagi Grimberg <sagi@grimberg.me> - 2017-09-25 07:40 +0200

csiph-web