Re: [PATCH net-next 1/4] net: dsa: remove copy of master ethtool_ops

From	Florian Fainelli <f.fainelli@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 1/4] net: dsa: remove copy of master ethtool_ops
Date	2017-09-19 22:00 +0200
Message-ID	<urwQA-1e6-53@gated-at.bofh.it> (permalink)
References	<urtfX-7CA-3@gated-at.bofh.it> <urtfX-7CA-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/19/2017 08:56 AM, Vivien Didelot wrote:
> There is no need to store a copy of the master ethtool ops, storing the
> original pointer in DSA and the new one in the master netdev itself is
> enough.
> 
> In the meantime, set orig_ethtool_ops to NULL when restoring the master
> ethtool ops and check the presence of the master original ethtool ops as
> well as its needed functions before calling them.

I clearly like memcpy() too much, this looks good:

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 1/4] net: dsa: remove copy of master ethtool_ops Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-09-19 18:10 +0200
  Re: [PATCH net-next 1/4] net: dsa: remove copy of master ethtool_ops Florian Fainelli <f.fainelli@gmail.com> - 2017-09-19 22:00 +0200

csiph-web