Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1735127

Re: [PATCH net-next 2/4] net: dsa: setup master ethtool unconditionally

From Florian Fainelli <f.fainelli@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH net-next 2/4] net: dsa: setup master ethtool unconditionally
Date 2017-09-19 19:50 +0200
Message-ID <uruOK-8qP-23@gated-at.bofh.it> (permalink)
References <urtfX-7CA-3@gated-at.bofh.it> <urtfZ-7CA-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 09/19/2017 08:56 AM, Vivien Didelot wrote:
> When a DSA switch tree is meant to be applied, it already has a CPU
> port. Thus remove the condition of dst->cpu_dp.
> 
> Moreover, the next lines access dst->cpu_dp unconditionally.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net-next 0/4] net: dsa: move master ethtool code Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-09-19 18:10 +0200
  [PATCH net-next 4/4] net: dsa: move master ethtool code Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-09-19 18:10 +0200
    Re: [PATCH net-next 4/4] net: dsa: move master ethtool code Florian Fainelli <f.fainelli@gmail.com> - 2017-09-19 22:00 +0200
  [PATCH net-next 2/4] net: dsa: setup master ethtool unconditionally Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-09-19 18:10 +0200
    Re: [PATCH net-next 2/4] net: dsa: setup master ethtool  unconditionally Florian Fainelli <f.fainelli@gmail.com> - 2017-09-19 19:50 +0200
  Re: [PATCH net-next 0/4] net: dsa: move master ethtool code Florian Fainelli <f.fainelli@gmail.com> - 2017-09-19 22:10 +0200
    Re: [PATCH net-next 0/4] net: dsa: move master ethtool code David Miller <davem@davemloft.net> - 2017-09-20 01:10 +0200

csiph-web