Re: [PATCH v3] tracing: Ignore mmiotrace from kernel commandline

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] tracing: Ignore mmiotrace from kernel commandline
Date	2017-09-19 18:30 +0200
Message-ID	<urtzk-7ID-9@gated-at.bofh.it> (permalink)
References	<uoqoh-7s2-1@gated-at.bofh.it> <uoqxX-7vR-9@gated-at.bofh.it> <uov4B-2t7-9@gated-at.bofh.it> <uoSkx-17B-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 12 Sep 2017 20:18:35 +0800
"Ziqian SUN (Zamir)" <zsun@redhat.com> wrote:

> >> I feel the core trace printed by WARN is not so meaningful, so I use
> >> pr_warn instead.  
> > 
> > I'm fine with pr_warn, but I'm curious to what you mean by "not so
> > meaningful"? A WARN() will cause a dump stack, which usually shows up
> > as a bug in systems and more likely to be seen. But if someone is
> > adding this to the kernel command line and it's not working, they
> > should be looking for the tracer name within the dmesg anyway.
> >   
> 
> Following is the log I tried with WARN before. With WARN we have both 
> the warning message, and the stack trace. The stack trace goes into 
> stacing_set_tracer, but not showing mmiotrace. I mean, this is useful 
> for debugging, but maybe confusing for users who is willing to report 
> bugs but not a kernel geek. With pr_warn we already indicate mmiotrace 
> is ignored, and is neat.
>

I'm now leaning towards WARN() over pr_warn(). Sure it's more useful
for a kernel geek and not an everyday user, but I will counter that an
everyday user should most definitely not be enabling mmiotrace! Or
other traces for that matter.

But then again, it's not really a bug (it's a feature), so I guess I'll
just take this patch as is.

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] tracing: Ignore mmiotrace from kernel commandline "Ziqian SUN (Zamir)" <zsun@redhat.com> - 2017-09-11 08:30 +0200
  Re: [PATCH v3] tracing: Ignore mmiotrace from kernel commandline "Ziqian SUN (Zamir)" <zsun@redhat.com> - 2017-09-11 08:40 +0200
    Re: [PATCH v3] tracing: Ignore mmiotrace from kernel commandline Steven Rostedt <rostedt@goodmis.org> - 2017-09-11 13:30 +0200
      Re: [PATCH v3] tracing: Ignore mmiotrace from kernel commandline "Ziqian SUN (Zamir)" <zsun@redhat.com> - 2017-09-12 14:20 +0200
        Re: [PATCH v3] tracing: Ignore mmiotrace from kernel commandline "Ziqian SUN (Zamir)" <zsun@redhat.com> - 2017-09-18 12:40 +0200
        Re: [PATCH v3] tracing: Ignore mmiotrace from kernel commandline Steven Rostedt <rostedt@goodmis.org> - 2017-09-19 18:30 +0200

csiph-web