Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1735053
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] KEYS: prevent KEYCTL_READ on negative key |
| Date | 2017-09-19 18:10 +0200 |
| Message-ID | <urtfY-7CA-23@gated-at.bofh.it> (permalink) |
| References | <ur97B-1vB-53@gated-at.bofh.it> |
| Organization | Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 |
Eric Biggers <ebiggers3@gmail.com> wrote:
> + if (test_bit(KEY_FLAG_NEGATIVE, &key->flags)) {
> + ret = -ENOKEY;
> + goto error2;
> + }
It might be better to do this check in key_validate(). Also, it should
perhaps take the error from key->reject_error.
David
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] KEYS: prevent KEYCTL_READ on negative key Eric Biggers <ebiggers3@gmail.com> - 2017-09-18 20:40 +0200
Re: [PATCH] KEYS: prevent KEYCTL_READ on negative key David Howells <dhowells@redhat.com> - 2017-09-19 18:10 +0200
Re: [PATCH] KEYS: prevent KEYCTL_READ on negative key Eric Biggers <ebiggers3@gmail.com> - 2017-09-22 01:40 +0200
Re: [PATCH] KEYS: prevent KEYCTL_READ on negative key David Howells <dhowells@redhat.com> - 2017-09-25 15:40 +0200
Re: [PATCH] KEYS: prevent KEYCTL_READ on negative key Eric Biggers <ebiggers3@gmail.com> - 2017-09-25 20:40 +0200
csiph-web