Re: [PATCH v2] VFS: Handle lazytime in do_mount()

From	Lukas Czerner <lczerner@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] VFS: Handle lazytime in do_mount()
Date	2017-09-19 17:30 +0200
Message-ID	<ursDg-7av-3@gated-at.bofh.it> (permalink)
References	<urnNf-47l-9@gated-at.bofh.it> <urnNf-47l-11@gated-at.bofh.it> <urnNf-47l-7@gated-at.bofh.it> <uro6B-4gb-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 19, 2017 at 12:37:24PM +0200, Markus Trippelsdorf wrote:
> Since commit e462ec50cb5fa ("VFS: Differentiate mount flags (MS_*) from
> internal superblock flags") the lazytime mount option didn't get passed
> on anymore.
> 
> Fix the issue by handling the option in do_mount().
> 
> Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
> ---
>  fs/namespace.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/namespace.c b/fs/namespace.c
> index 54059b142d6b..b633838b8f02 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -2823,7 +2823,8 @@ long do_mount(const char *dev_name, const char __user *dir_name,
>  			    SB_MANDLOCK |
>  			    SB_DIRSYNC |
>  			    SB_SILENT |
> -			    SB_POSIXACL);
> +			    SB_POSIXACL |
> +			    SB_LAZYTIME);

Looks good. Although I still think that this can be per mountpoint options.

Regardless of that, you can add
Reviewed-by: Lukas Czerner <lczerner@redhat.com>

>  
>  	if (flags & MS_REMOUNT)
>  		retval = do_remount(&path, flags, sb_flags, mnt_flags,
> -- 
> Markus

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] VFS: Handle lazytime in do_mount() Markus Trippelsdorf <markus@trippelsdorf.de> - 2017-09-19 12:20 +0200
  [PATCH v2] VFS: Handle lazytime in do_mount() Markus Trippelsdorf <markus@trippelsdorf.de> - 2017-09-19 12:40 +0200
    Re: [PATCH v2] VFS: Handle lazytime in do_mount() Lukas Czerner <lczerner@redhat.com> - 2017-09-19 17:30 +0200

csiph-web