Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1734909

Re: [PATCH 2/2] tee: optee: allow selection of ti-smc as a calling method

Show all headers | View raw

On Mon, Sep 18, 2017 at 3:50 PM, Andrew F. Davis <afd@ti.com> wrote:
> On TI platforms OP-TEE must be called using a modified SMC call,
> allow the selection of this though DT.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
>  Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt | 2 ++
>  drivers/tee/optee/core.c                                           | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt
> index d38834c67dff..a3275ecdf186 100644
> --- a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt
> +++ b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt
> @@ -20,6 +20,8 @@ the reference implementation maintained by Linaro.
>                     "hvc" : HVC #0, with the register assignments specified
>                            in drivers/tee/optee/optee_smc.h
>
> +                   "ti-smc" : Similar to "smc" with TI specific register
> +                             adjustments

Sigh, really? IMO, this should be determined from the compatible
string. Then the next TI (or any vendor) specific thing can be handled
without a DT change.

Maybe some day we'll figure out that not just h/w needs to be
probe-able, but all the firmware pieces do too.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] ARM: smccc-call: Use r12 to route secure monitor calls on TI platforms "Andrew F. Davis" <afd@ti.com> - 2017-09-18 23:00 +0200
  [PATCH 2/2] tee: optee: allow selection of ti-smc as a calling method "Andrew F. Davis" <afd@ti.com> - 2017-09-18 23:00 +0200
    Re: [PATCH 2/2] tee: optee: allow selection of ti-smc as a calling method Rob Herring <robh+dt@kernel.org> - 2017-09-19 15:40 +0200
      Re: [PATCH 2/2] tee: optee: allow selection of ti-smc as a calling  method "Andrew F. Davis" <afd@ti.com> - 2017-09-19 18:00 +0200
        Re: [PATCH 2/2] tee: optee: allow selection of ti-smc as a calling method Rob Herring <robh+dt@kernel.org> - 2017-09-19 23:20 +0200
    Re: [PATCH 2/2] tee: optee: allow selection of ti-smc as a calling  method Mark Rutland <mark.rutland@arm.com> - 2017-09-19 16:20 +0200
  Re: [PATCH 1/2] ARM: smccc-call: Use r12 to route secure monitor  calls on TI platforms Mark Rutland <mark.rutland@arm.com> - 2017-09-19 16:30 +0200
    Re: [PATCH 1/2] ARM: smccc-call: Use r12 to route secure monitor  calls on TI platforms "Andrew F. Davis" <afd@ti.com> - 2017-09-19 17:10 +0200
      Re: [PATCH 1/2] ARM: smccc-call: Use r12 to route secure monitor  calls on TI platforms Mark Rutland <mark.rutland@arm.com> - 2017-09-21 16:50 +0200

csiph-web