Re: [PATCH v3 03/13] perf report: create real callchain entries for inlined frames

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 03/13] perf report: create real callchain entries for inlined frames
Date	2017-09-19 14:30 +0200
Message-ID	<urpP5-5pF-21@gated-at.bofh.it> (permalink)
References	<umJ21-2yd-3@gated-at.bofh.it> <umJ23-2yd-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 06, 2017 at 03:54:51PM +0200, Milian Wolff wrote:

SNIP

>  
> -struct inline_node *dso__parse_addr_inlines(struct dso *dso, u64 addr);
> +// parse inlined frames for the given address
> +struct inline_node *dso__parse_addr_inlines(struct dso *dso, u64 addr,
> +					    struct symbol *sym);
> +// free resources associated to the inline node list
>  void inline_node__delete(struct inline_node *node);
>  
> +// insert the inline node list into the DSO, which will take ownership
> +void inlines__tree_insert(struct rb_root *tree, struct inline_node *inlines);
> +// find previously inserted inline node list
> +struct inline_node *inlines__tree_find(struct rb_root *tree, u64 addr);
> +// delete all nodes within the tree of inline_node s
> +void inlines__tree_delete(struct rb_root *tree);

nit, think we prefer the /* */ comment style

jirka

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v3 03/13] perf report: create real callchain entries for  inlined frames Jiri Olsa <jolsa@redhat.com> - 2017-09-19 14:30 +0200

csiph-web