[PATCH] usb: gadget: core: fix ->udc_set_speed() logic

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Roger Quadros <rogerq@ti.com>
Newsgroups	linux.kernel
Subject	[PATCH] usb: gadget: core: fix ->udc_set_speed() logic
Date	Tue, 19 Sep 2017 10:50:02 +0200
Message-ID	<urmoa-1TP-9@gated-at.bofh.it> (permalink)
X-Original-To	<balbi@kernel.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1505810781; bh=qegiygVsh9SmYgj9aCW7Fswbo1toDckpMXRp7SXVkBk=; h=From:To:CC:Subject:Date; b=m3oPq9hekGParLmW6oMIYGsXSyqg3I3m5Er3UIwuzOxb+VhOGGbzJj5ctsunIgp2z qJxx1JFfKdCWlu4vKeJU97EFo8rEqQ5UuA5qhknk7eRVG/fdTn9/vvARG//IfzHVXm ID9dGK6k0ZqBfbK8pX8tLDotMZPtCfvd4T5TN/aQ=
X-Mailer	git-send-email 2.7.4
MIME-Version	1.0
Content-Type	text/plain; charset="utf-8"
Content-Transfer-Encoding	quoted-printable
X-Exclaimer-Md-Config	e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	<vigneshr@ti.com>, <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Roger Quadros <rogerq@ti.com>, "[v4.13+]" <stable@vger.kernel.org>
X-Original-Date	Tue, 19 Sep 2017 11:46:16 +0300
X-Original-Message-ID	<1505810776-29361-1-git-send-email-rogerq@ti.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1734745

Show key headers only | View raw

Consider the following case: udc controller supports SuperSpeed.
If we first load a HighSpeed gadget followed by a SuperSpeed gadget,
the SuperSpeed gadget will be limited to HighSpeed as UDC core
driver doesn't call ->udc_set_speed() in the second case.

Call ->udc_set_speed() unconditionally to fix this issue.

This will also fix the case for dwc3 controller driver when SuperSpeed
gadget is loaded first and works in HighSpeed only as udc_set_speed()
was never being called.

Fixes: 6099eca796ae ("usb: gadget: core: introduce ->udc_set_speed() method")
Cc: <stable@vger.kernel.org> [v4.13+]
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 drivers/usb/gadget/udc/core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
index 75c51ca..d41d07a 100644
--- a/drivers/usb/gadget/udc/core.c
+++ b/drivers/usb/gadget/udc/core.c
@@ -1320,8 +1320,7 @@ static int udc_bind_to_driver(struct usb_udc *udc, struct usb_gadget_driver *dri
 	udc->dev.driver = &driver->driver;
 	udc->gadget->dev.driver = &driver->driver;
 
-	if (driver->max_speed < udc->gadget->max_speed)
-		usb_gadget_udc_set_speed(udc, driver->max_speed);
+	usb_gadget_udc_set_speed(udc, driver->max_speed);
 
 	ret = driver->bind(udc->gadget, driver);
 	if (ret)
-- 
2.7.4


Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] usb: gadget: core: fix ->udc_set_speed() logic Roger Quadros <rogerq@ti.com> - 2017-09-19 10:50 +0200

csiph-web