[PATCH] sysctl: remove duplicate UINT_MAX check on do_proc_douintvec_conv()

From	"Luis R. Rodriguez" <mcgrof@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH] sysctl: remove duplicate UINT_MAX check on do_proc_douintvec_conv()
Date	2017-09-19 09:30 +0200
Message-ID	<url8K-1bj-13@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

do_proc_douintvec_conv() has two UINT_MAX checks, we can remove one.
This has no functional changes other than fixing a compiler warning:

kernel/sysctl.c:2190]: (warning) Identical condition '*lvalp>UINT_MAX', second condition is always false

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
 kernel/sysctl.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 4c08ed4a379e..0da31bbbff18 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -2181,8 +2181,6 @@ static int do_proc_douintvec_conv(unsigned long *lvalp,
 				  int write, void *data)
 {
 	if (write) {
-		if (*lvalp > UINT_MAX)
-			return -EINVAL;
 		if (*lvalp > UINT_MAX)
 			return -EINVAL;
 		*valp = *lvalp;
-- 
2.14.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] sysctl: remove duplicate UINT_MAX check on do_proc_douintvec_conv() "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-09-19 09:30 +0200
  Re: [PATCH] sysctl: remove duplicate UINT_MAX check on do_proc_douintvec_conv() Kees Cook <keescook@chromium.org> - 2017-09-20 00:00 +0200

csiph-web