Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1734704

Re: [PATCH 1/2] [RESEND] of: provide of_n_{addr,size}_cells wrappers for !CONFIG_OF

Show all headers | View raw

Hi Rob,

On Mon, Sep 18, 2017 at 11:28 PM, Rob Herring <robh+dt@kernel.org> wrote:
> On Mon, Sep 11, 2017 at 3:07 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> The pci-rcar driver is enabled for compile tests, and this has
>> shown that the driver cannot build without CONFIG_OF,
>> following the inclusion of f8f2fe7355fb "PCI: rcar: Use new OF
>> interrupt mapping when possible":
>>
>> drivers/pci/host/pcie-rcar.c: In function 'pci_dma_range_parser_init':
>> drivers/pci/host/pcie-rcar.c:1039:2: error: implicit declaration of function 'of_n_addr_cells' [-Werror=implicit-function-declaration]
>>   parser->pna = of_n_addr_cells(node);
>>   ^
>> As pointed out by Ben Dooks and Geert Uytterhoeven, this is actually
>> supposed to build fine, which we can achieve if we make the
>> declaration of of_irq_parse_and_map_pci conditional on CONFIG_OF
>> and provide an empty inline function otherwise, as we do for
>> a lot of other of interfaces.
>>
>> This lets us build the rcar_pci driver again without CONFIG_OF
>> for build testing. All platforms using this driver select OF,
>> so this doesn't change anything for the users.
>
> Sorry, I keep missing this. It's a flaw in my mail filtering...
>
> There's a patch series[1] to factor out pci_dma_range_parser_init of
> the driver which should also fix this. I'd prefer not to take this
> because ideally all address parsing should be within the DT core code.
>
> Rob
>
> [1] https://patchwork.kernel.org/patch/9927541/

Yes, that looks like a better solution.

(For those who didn't see the rest of the series: of_pci_dma_range_parser_init()
 in provided in of/address.c, and does have a dummy)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] [RESEND] of: provide of_n_{addr,size}_cells wrappers for !CONFIG_OF Arnd Bergmann <arnd@arndb.de> - 2017-09-11 22:10 +0200
  [PATCH 2/2] of: provide inline helper for of_find_device_by_node Arnd Bergmann <arnd@arndb.de> - 2017-09-11 22:10 +0200
  Re: [PATCH 1/2] [RESEND] of: provide of_n_{addr,size}_cells wrappers  for !CONFIG_OF Rob Herring <robh+dt@kernel.org> - 2017-09-18 23:30 +0200
    Re: [PATCH 1/2] [RESEND] of: provide of_n_{addr,size}_cells wrappers  for !CONFIG_OF Geert Uytterhoeven <geert@linux-m68k.org> - 2017-09-19 09:10 +0200

csiph-web