Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1734616
| From | Josh Poimboeuf <jpoimboe@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 2/8] x86/head: Remove confusing comment |
| Date | 2017-09-19 04:50 +0200 |
| Message-ID | <urgLL-6I2-17@gated-at.bofh.it> (permalink) |
| References | <urgLL-6I2-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
This comment is actively wrong and confusing. It refers to the registers' stack offsets after the pt_regs has been constructed on the stack, but this code is *before* that. At this point the stack just has the standard iret frame, for which no comment should be needed. Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> --- arch/x86/kernel/head_64.S | 4 ---- 1 file changed, 4 deletions(-) diff --git a/arch/x86/kernel/head_64.S b/arch/x86/kernel/head_64.S index 513cbb012ecc..3b04e4c99389 100644 --- a/arch/x86/kernel/head_64.S +++ b/arch/x86/kernel/head_64.S @@ -270,10 +270,6 @@ bad_address: __INIT ENTRY(early_idt_handler_array) - # 104(%rsp) %rflags - # 96(%rsp) %cs - # 88(%rsp) %rip - # 80(%rsp) error code i = 0 .rept NUM_EXCEPTION_VECTORS .ifeq (EXCEPTION_ERRCODE_MASK >> i) & 1 -- 2.13.5
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/8] x86/asm: Add unwind hint annotations to head code Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-19 04:50 +0200 [PATCH v2 8/8] x86/head: Add unwind hint annotations Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-19 04:50 +0200 [PATCH v2 2/8] x86/head: Remove confusing comment Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-19 04:50 +0200 [PATCH v2 3/8] x86/head: Remove unused 'bad_address' code Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-19 04:50 +0200
csiph-web