Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1734549
| From | Christoph Hellwig <hch@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] block: move sanity checking ahead of bi_front/back_seg_size updating |
| Date | 2017-09-19 02:00 +0200 |
| Message-ID | <ure7g-4Xi-9@gated-at.bofh.it> (permalink) |
| References | <upT4T-7Zg-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Sep 16, 2017 at 07:10:30AM +0800, Jianchao Wang wrote: > If the bio_integrity_merge_rq() return false or nr_phys_segments exceeds > the max_segments, the merging fails, but the bi_front/back_seg_size may > have been modified. To avoid it, move the sanity checking ahead. > > Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com> This looks fine to me: Reviewed-by: Christoph Hellwig <hch@lst.de> But can you elaborate a little more on how this found and if there is a way to easily reproduce it, say for a blktests test case?
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] block: move sanity checking ahead of bi_front/back_seg_size updating Jianchao Wang <jianchao.w.wang@oracle.com> - 2017-09-15 09:20 +0200
Re: [PATCH] block: move sanity checking ahead of bi_front/back_seg_size updating Christoph Hellwig <hch@infradead.org> - 2017-09-19 02:00 +0200
Re: [PATCH] block: move sanity checking ahead of bi_front/back_seg_size updating "jianchao.wang" <jianchao.w.wang@oracle.com> - 2017-09-19 03:00 +0200
Re: [PATCH] block: move sanity checking ahead of bi_front/back_seg_size updating Christoph Hellwig <hch@infradead.org> - 2017-09-19 16:40 +0200
Re: [PATCH] block: move sanity checking ahead of bi_front/back_seg_size updating "jianchao.wang" <jianchao.w.wang@oracle.com> - 2017-09-20 03:40 +0200
csiph-web